Add cursor_position property to Completion #325
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @koljonen for this. This is definitely useful. I think there are a few situations that are not correctly handled in the pull request which I'll have to check later on. And also, I'm not entirely sure that I want to expand |
`cursor_position` says how far from the end of the completion the cursor should be placed, so that we can have completions such as e.g. `<html[cursor]` -> `<html>[cursor]</html>`.
koljonen
force-pushed
the
completion_cursor_position
branch
from
328ca39 to
4bfc18d
Compare
|
I've squashed away the changes to WordCompleter. |
|
Can you rebase @koljonen? |
jonathanslenders
force-pushed
the
master
branch
from
2abbf7d to
548a99e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursor_positionsays how far from the end of the completion the cursor should be placed, so that we can have completions such as e.g.<html[cursor]-><html>[cursor]</html>.