fix: point pdd-change Step 6 dependency context at <pdd-dependency>, not <include> - #2373
Closed
agarwal-ishaan wants to merge 3 commits into
Closed
Conversation
…not <include> Step 6's _build_dependency_context() currently builds its module-dependency graph by scanning <include> tags (build_dependency_graph()), but <include> tags are LLM context, not declared architectural dependencies. A module can truly depend on another via <pdd-dependency> without ever <include>-ing it, and can <include> another module's example purely for style without depending on it at all -- so the current graph both misses real dependents and fabricates false ones. Updates the source prompts (not the generated code yet) to specify a new sync_order.build_dependency_graph_from_architecture() that reads architecture.json's `dependencies` field (already populated from <pdd-dependency> tags by architecture_sync.py) and wires it into Step 6's dependency context instead. Fixes promptdriven#1807 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
agarwal-ishaan
temporarily deployed
to
pdd-cloud-read
August 6, 2026 06:14 — with
GitHub Actions
Inactive
agarwal-ishaan
temporarily deployed
to
pdd-cloud-read
August 6, 2026 14:24 — with
GitHub Actions
Inactive
agarwal-ishaan
temporarily deployed
to
pdd-cloud-read
August 6, 2026 14:32 — with
GitHub Actions
Inactive
This was referenced Aug 6, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pdd changeStep 6 builds its module-dependency context by scanning<include>tags (build_dependency_graph()), but<include>tags are LLM context, not declared architectural dependencies -- so the graph both misses real<pdd-dependency>-declared dependents and fabricates false ones from stylistic includes.sync_order.build_dependency_graph_from_architecture()that readsarchitecture.json'sdependenciesfield (already populated from<pdd-dependency>tags byarchitecture_sync.py), and wires Step 6's_build_dependency_context()to use it instead.pdd generate --incrementalonpdd/sync_order.pyandpdd/agentic_change_orchestrator.py) is pending in a follow-up PR -- Anthropic API access is currently blocked by a billing issue, and the fallback Gemini model hits its output-token ceiling trying to patch the ~4000-line orchestrator file. Once resolved, the code PR will implement exactly what's specified here.Fixes #1807
Test plan
pdd/sync_order.pyandpdd/agentic_change_orchestrator.pyfrom these prompts viapdd generate --incrementalbuild_dependency_graph_from_architecture()and the updated_build_dependency_context()<pdd-dependency>on another without<include>-ing it shows up correctly as a dependent; a module<include>-ing another purely for style context does not