make non-zk proofs work again#1
Open
nalinbhardwaj wants to merge 2 commits into
Open
Conversation
dcposch
approved these changes
Nov 14, 2023
| const label = state.anonymous | ||
| ? text("🕶️", "Welcome, anon") | ||
| : text("👓", state.participant.name); | ||
| : text("👓", state.participant.email); |
| signal, | ||
| externalNullifier, | ||
| }; | ||
| throw new Error("Anonymous login not implemented"); |
Contributor
There was a problem hiding this comment.
just curious, what broke about this part? it was very generic---you pass in a groupURL , can be any semphore group not necessarily zuzalu related
Author
There was a problem hiding this comment.
Similar to the other one, importing stuff from the core @pcd/* packages is broken ATM (esoteric errors that are quite hard to debug). That one I fixed by vendoring, slowly commenting out stuff and finding what's broken. Will have to do the same for this but would be a lot of effort since this path had a lot of imports internally.
ideally should just fix the issues in main pcd repo instead.
| status: "logged-out" | "logged-in"; | ||
| anonymous?: boolean; | ||
| participant?: ZuParticipant; | ||
| participant?: User; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrades and vendoring in passport interface files
screen-record-zukit.mov