fix(react): polish the link editor popover - #545
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe link menu adds themeable input tokens, revised form and button styling, destination-input focus behavior, guarded save validation, conditional link removal, and tests for keyboard-driven creation and editing. ChangesLink menu updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The link editor now focuses the URL field, prevents incomplete saves, and hides removal for new links, with interaction coverage for these flows. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
packages/core/src/style.cssESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/react/src/components/link-menu.module.cssESLint skipped: the matched ESLint configuration already failed (missing-dependency). packages/react/src/components/link-menu.module.d.css.tsESLint skipped: the matched ESLint configuration already failed (missing-dependency).
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
The link editor now opens on the Link field (selected when editing an existing link), only offers
Remove linkfor an existing link, right-alignsSave, and disables it until both fields are filled instead of relying on the nativerequiredbubble. Inputs get a visible resting border plus a soft focus ring through the new--meowdown-input-border/--meowdown-focus-ringvariables, and the buttons get hover, active, and focus-visible states.Summary by CodeRabbit
Bug Fixes
Style