chore(deps): bump fast-csv 4 → 5 and unzipper 0.10 → 0.12 to clear deprecations#62
Closed
senoff wants to merge 1 commit into
Closed
chore(deps): bump fast-csv 4 → 5 and unzipper 0.10 → 0.12 to clear deprecations#62senoff wants to merge 1 commit into
senoff wants to merge 1 commit into
Conversation
…precations Bumps two prod dependencies whose stale transitive trees produce npm install warnings in any project that takes @protobi/exceljs as a (transitive) dep: - fast-csv 4.3.1 → 5.0.0 Drops `lodash.isequal@4.5.0` (deprecated in favour of `node:util.isDeepStrictEqual`). fast-csv@5 uses the node-builtin instead. - unzipper 0.10.11 → 0.12.3 Drops the fstream → rimraf@2 → glob@7 → inflight chain. unzipper@0.12 replaced fstream with a streams-only path; all four deprecations fall out in one bump. No source-code changes are required — both libraries' public APIs that exceljs uses (`fastCsv.format`, `unzipper.Open.buffer`, etc.) are unchanged. Round-trip write/read + CSV writeBuffer smoke-tested clean against this branch. Companion to protobi#60 (uuid bump). Together the three direct-dep bumps clear all but one of the deprecation warnings consumers see on `npm install` of any project that pulls @protobi/exceljs in. The remaining warning (glob@10.5.0 via archiver-utils) needs a fix in the archiver package and is out of scope here.
Author
|
Ran the full headless test suite ( (Skipped So both bumps survive the existing suite cleanly with no source changes. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small prod-dep bumps that drop five
npm installdeprecation warnings in any project that takes@protobi/exceljsas a dependency. Companion to #60 (uuid bump).Why
Anyone running
npm installof a project that depends on @protobi/exceljs currently sees these warnings:inflight@1.0.6(deprecated, leaks memory)rimraf@2.7.1(pre-v4 unsupported)lodash.isequal@4.5.0(deprecated; recommendsnode:util.isDeepStrictEqual)glob@7.2.3(security advisories)fstream@1.0.12(no longer supported)All five trace back to two of exceljs's prod deps:
What changes
fast-csv4.3.1 → 5.0.0 — fast-csv@5 droppedlodash.isequalin favour of thenode:util.isDeepStrictEqualbuiltin. No API changes affecting exceljs's call sites.unzipper0.10.11 → 0.12.3 — unzipper@0.12 replacedfstreamwith a streams-only path; the entirefstream → rimraf@2 → glob@7 → inflightchain falls out in one bump. No API changes affecting exceljs's call sites.No source-code changes are required.
Validation
npm installreproduces the dep tree shape shown above before the bumps; after the bumps the five listed warnings are gone (verified the prod-only tree withnpm install --omit=dev).Companion to #60
Together with #60 (uuid bump), this clears six of the seven deprecation warnings consumers see on install. The remaining one (
glob@10.5.0viaarchiver-utils) needs a fix in thearchiverproject and is out of scope here — that's a notice from the third-party glob maintainer rather than an exceljs-tree issue.Happy to split this into two separate PRs if you'd prefer to review them independently.