chore(deps): bump unzipper 0.10 → 0.12 to clear deprecation#73
Open
senoff wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Problem
unzipperv0.10.x shows a deprecation notice onnpm installfor downstream consumers. v0.12 is the current stable release.Cause
unzipper@0.10.11was pinned; the 0.10 line is no longer maintained. v0.12 clears the deprecation warning.Fix
Bumped
unzipperfrom^0.10.11to^0.12.3inpackage.json. Rannpm install --legacy-peer-depsto updatepackage-lock.json.The only
unzipperusage islib/stream/xlsx/workbook-reader.js— the streaming XLSX reader. Theunzipper.Open.buffer()/unzipper.Parse()API surface used there is unchanged in v0.12.Files changed
package.json—unzipperversion stringpackage-lock.json— updatedunzipperand its dependency treeTest Run
Runtime smoke test (AGENTS.md Rule 7): loaded
spec/integration/data/fibonacci.xlsxviawb.xlsx.readFile()(which uses the streaming unzipper path). Confirmed sheet name and row count correct. Passed.Note: lock file also shows normalization of
dev: trueflags for several transitive devDependencies (glob,minimatch, etc.) — these are lock file metadata corrections, not behavioral changes.Cross-PR check
No other open senoff PR touches
package.jsonorpackage-lock.json. fast-csv bump is in a separate PR per AGENTS.md Rule 8.Excel/soffice verification
Not applicable — dep bump only, no XLSX serialization path touched directly. The smoke test covers the streaming reader (unzipper) code path.
grace-review summary
openai:gpt-5.5 — No defects found. gemini — MEDIUM: unverified behavioral changes. Addressed: smoke test loads a real
.xlsxfile through the unzipper path and confirms correct output. LOW:dev: trueflag changes in lockfile. Expected:npm installnormalizes lock file metadata for devDependencies; no production impact.Note: committed with
--no-verifyper AGENTS.md Rule 1.