feat: add reconciliation supervisor foundation#240
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a process supervisor with readiness checks, a scoped reconciliation queue + debouncer wired into job handling and server, a SQLite-backed port allocator and secure filesystem helpers, and tests exercising reconciliation, supervision, readiness, and port allocation. ChangesProcess Supervision Infrastructure
Reconciliation Queue and Job Orchestration
Port Allocation System
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
crates/state/src/lib.rs (1)
32-33: ⚡ Quick winUse a top-level import instead of a fully-qualified call in
testing::read_to_string.♻️ Suggested refactor
pub mod testing { use rusqlite::Transaction; pub use crate::migrations::Migration; - use crate::{Database, PvPaths, StateError}; + use crate::{Database, PvPaths, StateError, fs}; @@ pub fn read_to_string(path: &camino::Utf8Path) -> Result<String, StateError> { - crate::fs::read_to_string(path) + fs::read_to_string(path) }As per coding guidelines, "PREFER top-level imports over local imports or fully qualified names in Rust".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/state/src/lib.rs` around lines 32 - 33, Replace the fully-qualified call to crate::fs::read_to_string inside the testing read_to_string function with a top-level import and direct call: add a use crate::fs::read_to_string; at the top of the module (or crate root as appropriate) and then call read_to_string(path) inside the pub fn read_to_string(...) -> Result<String, StateError> so the function uses the imported symbol instead of the fully-qualified name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/daemon/src/reconciliation.rs`:
- Around line 75-89: The enqueue/QueuedReconciliation API must be made
drop-safe: remove Clone from QueuedReconciliation and return a non-cloneable
guard that automatically releases/cleans up its queue state in Drop (so canceled
or dropped tokens cannot leave queued.front() or active stuck). Specifically,
modify enqueue to produce a guard type (replace current QueuedReconciliation)
which on Drop will (1) acquire inner.state lock, remove itself from queued if
still queued, or if it is active clear active and pop the next queued entry, and
(2) call inner.notify.notify_waiters() after modifying state; also ensure
wait_for_turn/finish become internal to the guard or are folded into an
awaitable method on the guard so explicit finish is not required. Update any
uses of QueuedReconciliation, wait_for_turn, and finish to use the new guard API
and ensure the guard is not Clone to prevent misuse.
In `@crates/daemon/src/supervisor.rs`:
- Around line 83-84: The post-spawn persistence calls (fs::write_sensitive_file
and write_runtime_metadata) can fail and currently return Err while leaving the
spawned child running; modify the start function so that if either write fails
you immediately terminate the spawned process (the Child instance named child)
and await/handle its exit before returning Err. Specifically, after spawning
(where child is created) wrap the fs::write_sensitive_file and
write_runtime_metadata calls in a fallible block and on any Err call
child.kill() (or child.kill().await for tokio::process::Child), then call
child.wait()/await to reap it, log or propagate any kill/wait errors as
appropriate, and finally return the original persistence error.
- Around line 113-119: The call to kill_process_group in stop can fail if the
target process group already exited; change the
kill_process_group(process_group, Signal::TERM).map_err(...) pattern to
explicitly handle "no such process" (ESRCH) as non-fatal: call
kill_process_group(process_group, Signal::TERM), match the Result, and if Err
map to an io::Error and check e.raw_os_error()==Some(libc::ESRCH) (or equivalent
platform-specific code) then ignore it and continue, otherwise return the mapped
error; do the same defensive handling for the later kill_process_group(...,
Signal::KILL) so stop and the child.wait() path remain resilient when the
process/group is already gone.
In `@crates/state/src/database.rs`:
- Around line 248-262: The NoAvailablePort error always reports
PORT_CANDIDATE_LIMIT even when fewer candidates were actually tried; modify the
loop in the function that iterates request.candidates() to count the real number
of candidate checks (increment a local attempts counter each iteration that
isn't skipped by assigned_ports/!is_available) and use that counter when
constructing StateError::NoAvailablePort instead of PORT_CANDIDATE_LIMIT; this
touches the loop that calls request.candidates(), the call to
self.upsert_port(request, candidate), and the StateError::NoAvailablePort
construction so the reported attempts accurately reflect how many distinct
candidates were evaluated.
In `@crates/state/src/fs.rs`:
- Line 154: The current temporary_path uses path.with_extension("tmp") which
collides for different extensions; change the temp derivation to avoid
collisions by appending a unique suffix instead of replacing the extension.
Replace the use of path.with_extension("tmp") (variable temporary_path) with a
construction that keeps the original filename and adds a non-colliding suffix
(for example: path.with_file_name(format!("{}.{}.tmp",
path.file_name().unwrap().to_string_lossy(), std::process::id())) or include a
UUID via uuid::Uuid::new_v4()), or create a temp file atomically in the same
directory using
tempfile::Builder::new().prefix(...).tempfile_in(path.parent().unwrap()) and use
its path; ensure the change is applied where temporary_path is referenced in
crates::state::fs (the variable temporary_path and the code that writes/renames
it).
---
Nitpick comments:
In `@crates/state/src/lib.rs`:
- Around line 32-33: Replace the fully-qualified call to
crate::fs::read_to_string inside the testing read_to_string function with a
top-level import and direct call: add a use crate::fs::read_to_string; at the
top of the module (or crate root as appropriate) and then call
read_to_string(path) inside the pub fn read_to_string(...) -> Result<String,
StateError> so the function uses the imported symbol instead of the
fully-qualified name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 63da7c0e-6495-4817-af64-ef4ed6573131
⛔ Files ignored due to path filters (4)
Cargo.lockis excluded by!**/*.lockcrates/daemon/tests/snapshots/daemon_foundation__valid_reconciliation_scopes_stream_stub_completion.snapis excluded by!**/*.snapcrates/daemon/tests/snapshots/supervisor_foundation__supervisor_captures_logs_and_runtime_metadata_then_stops_child.snapis excluded by!**/*.snapcrates/state/tests/snapshots/state_foundation__port_allocator_persists_reuses_avoids_collisions_and_releases_assignments.snapis excluded by!**/*.snap
📒 Files selected for processing (14)
crates/daemon/Cargo.tomlcrates/daemon/src/error.rscrates/daemon/src/jobs.rscrates/daemon/src/lib.rscrates/daemon/src/reconciliation.rscrates/daemon/src/server.rscrates/daemon/src/supervisor.rscrates/daemon/tests/daemon_foundation.rscrates/daemon/tests/supervisor_foundation.rscrates/state/src/database.rscrates/state/src/error.rscrates/state/src/fs.rscrates/state/src/lib.rscrates/state/tests/state_foundation.rs
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/daemon/src/watcher.rs`:
- Around line 38-41: The loop in run is currently discarding poll_once() errors
(let _result = ...), so change it to explicitly handle the Result from
self.poll_once().await: match or if let Err(e) = self.poll_once().await { ... }
and log/report the error (e.g., via the crate logger or a provided reporter)
instead of ignoring it; optionally decide whether to retry, backoff, or
return/propagate the error to the task owner rather than swallowing it. Ensure
you remove the unused underscore binding and reference the symbols run,
poll_once, and poll_interval when locating the change.
In `@crates/daemon/tests/daemon_foundation.rs`:
- Around line 287-290: The 250ms sleep before the second write in the test can
be too short for coarse mtime filesystems causing the write to appear unchanged;
update the test around tokio::time::sleep(Duration::from_millis(250)).await and
state::fs::write_sensitive_file(...) so it either sleeps long enough (e.g.,
>=1s) or actively polls file metadata (using tokio::fs::metadata and checking
modified_at/mtime) in a loop until the mtime changes before calling
wait_for_job_scope(&paths, "project:project_1").await; ensure you reference the
existing helpers (state::fs::write_sensitive_file and wait_for_job_scope) and
fail the test if a reasonable timeout is reached.
In `@crates/daemon/tests/supervisor_foundation.rs`:
- Line 100: The timing assertion using started_at.elapsed() <
Duration::from_millis(200) is too tight and can flake in CI; update both
occurrences (the assertion at started_at.elapsed() and the similar one at the
other location) to use a more lenient bound—e.g., Duration::from_millis(250) or,
better, the test's configured timeout constant—so replace
Duration::from_millis(200) with the configured timeout (or 250ms) to give
scheduling margin, or alternatively change the check to only assert
timeout/error semantics instead of strict low-latency timing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1fca4061-a7eb-49ff-a0f3-6927522345d0
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (13)
crates/daemon/Cargo.tomlcrates/daemon/src/jobs.rscrates/daemon/src/lib.rscrates/daemon/src/reconciliation.rscrates/daemon/src/server.rscrates/daemon/src/supervisor.rscrates/daemon/src/watcher.rscrates/daemon/tests/daemon_foundation.rscrates/daemon/tests/supervisor_foundation.rscrates/state/src/database.rscrates/state/src/fs.rscrates/state/src/lib.rscrates/state/tests/state_foundation.rs
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
crates/daemon/tests/daemon_foundation.rs (1)
360-367: ⚡ Quick winUse top-level imports for
Utf8Pathandstate::fsinwrite_file_after_modified_time_tick.The helper currently uses fully-qualified
camino::Utf8Pathandstate::fs::*; importing these at module level keeps the test consistent.♻️ Proposed refactor
use anyhow::{Result, anyhow}; +use camino::Utf8Path; use camino_tempfile::tempdir; @@ -use state::{Database, JobRecord, PvPaths}; +use state::{Database, JobRecord, PvPaths, fs}; @@ -async fn write_file_after_modified_time_tick(path: &camino::Utf8Path, content: &str) -> Result<()> { - let before = state::fs::modified_at(path)?; +async fn write_file_after_modified_time_tick(path: &Utf8Path, content: &str) -> Result<()> { + let before = fs::modified_at(path)?; @@ - state::fs::write_sensitive_file(path, content)?; + fs::write_sensitive_file(path, content)?; @@ - if state::fs::modified_at(path)? != before { + if fs::modified_at(path)? != before { return Ok(()); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/daemon/tests/daemon_foundation.rs` around lines 360 - 367, Replace the inline fully-qualified types and module paths in write_file_after_modified_time_tick with top-level imports: add a module-level use for camino::Utf8Path (or Utf8Path as the name used elsewhere) and a use for state::fs (or use state::fs::* if that matches project style), then update the function signature and calls to use Utf8Path and fs::modified_at/fs::write_sensitive_file (or direct function names if using glob import) instead of camino::Utf8Path and state::fs::... so the helper matches the test module's import style.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/daemon/src/watcher.rs`:
- Around line 91-92: Replace fully-qualified state:: references with top-level
imports: add state::{PvPaths, fs} to the imports and update uses so
PvPaths::for_home(...) and fs::write_sensitive_file(...) are called instead of
state::PvPaths and state::fs; specifically adjust the test code that currently
calls state::PvPaths::for_home and state::fs::write_sensitive_file to use
PvPaths and fs to keep module import style consistent.
---
Nitpick comments:
In `@crates/daemon/tests/daemon_foundation.rs`:
- Around line 360-367: Replace the inline fully-qualified types and module paths
in write_file_after_modified_time_tick with top-level imports: add a
module-level use for camino::Utf8Path (or Utf8Path as the name used elsewhere)
and a use for state::fs (or use state::fs::* if that matches project style),
then update the function signature and calls to use Utf8Path and
fs::modified_at/fs::write_sensitive_file (or direct function names if using glob
import) instead of camino::Utf8Path and state::fs::... so the helper matches the
test module's import style.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2c9df7f5-9b25-44ff-b927-9824ab9ae2bc
📒 Files selected for processing (4)
crates/daemon/src/server.rscrates/daemon/src/watcher.rscrates/daemon/tests/daemon_foundation.rscrates/daemon/tests/supervisor_foundation.rs
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/daemon/src/jobs.rs (1)
63-89:⚠️ Potential issue | 🟠 Major | ⚡ Quick winDon’t let the initial response write mask reconciliation completion failures.
If
write_linefor the accepted response fails,accepted_result?returns beforeresult, so a latercomplete_stub_reconciliation/DB error is dropped. That can leave the job lifecycle broken while the caller only sees a transport failure.♻️ Proposed fix
let result = stream_started_reconciliation_job( paths, transport, stream_is_open, running.job_id(), &scope_text, ) .await; running.finish(); - accepted_result?; - - result + result?; + accepted_result?; + Ok(()) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/daemon/src/jobs.rs` around lines 63 - 89, The transport write result (accepted_result) is currently propagated before awaiting/returning the reconciliation result from stream_started_reconciliation_job, which can hide reconciliation/DB errors; change the control flow so you await and capture result first, then propagate errors giving precedence to the reconciliation result: call stream_started_reconciliation_job(...).await and store its Result, call running.finish(), then handle accepted_result and the reconciliation result such that if reconciliation (result) is Err it is returned to the caller, otherwise return accepted_result (or Ok) as appropriate; refer to write_line/accepted_result, stream_started_reconciliation_job, result, and running.finish in the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/daemon/src/supervisor.rs`:
- Line 137: The current check uses command_line.contains(spec.command.as_str())
which may match arguments instead of the real executable; update live-process
executable matching in live_process_matches_spec (and the related checks around
metadata.matches usage) to compare the actual process executable path or argv[0]
instead of substring matching: obtain the process executable via /proc/<pid>/exe
(e.g., std::fs::read_link) or parse argv[0] from the proc cmdline and compare it
exactly (or canonicalize paths) against spec.command, replacing the
contains(...) call with this exact/executable-path comparison to avoid false
positives.
In `@crates/daemon/src/watcher.rs`:
- Around line 51-63: The code currently converts every fs::modified_at error
into modified_at: None; instead, only treat explicit "unreadable/invalid path"
errors as tolerable and set WatchedConfig.modified_at = None, and let all other
errors propagate so run() can observe them. Update the Err(_error) arm in the
fs::modified_at match to inspect the io::Error (from fs::modified_at) and match
on error.kind() (e.g., NotFound, InvalidInput, PermissionDenied if desired) and
only insert current_configs.insert(watch.project_id, WatchedConfig { path:
watch.config_path, modified_at: None }) and continue for those kinds; for any
other error kind, return or propagate the error (so run() receives it) rather
than swallowing it.
---
Outside diff comments:
In `@crates/daemon/src/jobs.rs`:
- Around line 63-89: The transport write result (accepted_result) is currently
propagated before awaiting/returning the reconciliation result from
stream_started_reconciliation_job, which can hide reconciliation/DB errors;
change the control flow so you await and capture result first, then propagate
errors giving precedence to the reconciliation result: call
stream_started_reconciliation_job(...).await and store its Result, call
running.finish(), then handle accepted_result and the reconciliation result such
that if reconciliation (result) is Err it is returned to the caller, otherwise
return accepted_result (or Ok) as appropriate; refer to
write_line/accepted_result, stream_started_reconciliation_job, result, and
running.finish in the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 72594690-8b63-4b43-9488-8683b6f1cfcd
⛔ Files ignored due to path filters (2)
crates/daemon/tests/snapshots/daemon_foundation__invalid_reconciliation_scope_reports_scope_parse_failure.snapis excluded by!**/*.snapcrates/daemon/tests/snapshots/supervisor_foundation__supervisor_captures_logs_and_runtime_metadata_then_stops_child.snapis excluded by!**/*.snap
📒 Files selected for processing (8)
crates/daemon/src/error.rscrates/daemon/src/jobs.rscrates/daemon/src/lib.rscrates/daemon/src/reconciliation.rscrates/daemon/src/supervisor.rscrates/daemon/src/watcher.rscrates/daemon/tests/daemon_foundation.rscrates/daemon/tests/supervisor_foundation.rs
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/state/src/database.rs (1)
512-523: ⚡ Quick winUse a typed component discriminator to remove the impossible fallback path.
validate_componentcurrently relies on string literals and a default arm for a scenario that should be impossible from call sites. Encoding the component as an enum makes this exhaustive at compile time and removes dead fallback handling.♻️ Proposed refactor
+enum PortOwnerComponent { + ProjectId, + PhpTrack, + Name, + Track, +} + impl PortOwner { @@ - self.validate_component("project_id", project_id)?; - self.validate_component("php_track", php_track)?; + self.validate_component(PortOwnerComponent::ProjectId, project_id)?; + self.validate_component(PortOwnerComponent::PhpTrack, php_track)?; @@ - self.validate_component("name", name)?; - self.validate_component("track", track)?; + self.validate_component(PortOwnerComponent::Name, name)?; + self.validate_component(PortOwnerComponent::Track, track)?; @@ - fn validate_component(&self, component: &'static str, value: &str) -> Result<(), StateError> { + fn validate_component( + &self, + component: PortOwnerComponent, + value: &str, + ) -> Result<(), StateError> { if value.is_empty() { return Err(StateError::InvalidPortOwner { owner: self.display_name(), reason: match component { - "project_id" => "project worker port owner project id must not be empty", - "php_track" => "project worker port owner php track must not be empty", - "name" => "resource port owner name must not be empty", - "track" => "resource port owner track must not be empty", - _ => "port owner component must not be empty", + PortOwnerComponent::ProjectId => { + "project worker port owner project id must not be empty" + } + PortOwnerComponent::PhpTrack => { + "project worker port owner php track must not be empty" + } + PortOwnerComponent::Name => "resource port owner name must not be empty", + PortOwnerComponent::Track => "resource port owner track must not be empty", }, }); }As per coding guidelines, "Avoid error handling for impossible scenarios in Rust".
Also applies to: 572-583
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/state/src/database.rs` around lines 512 - 523, The code uses validate_component(&str) with string literals and a catch-all path; change validate_component to accept a typed enum (e.g., enum Component { ProjectId, PhpTrack, Name, Track }) and update all call sites in the PortIdentity match arms (the Self::Project and Self::Resource branches) to pass the appropriate Component variant instead of string literals, so validation is exhaustive at compile time and the impossible fallback can be removed; also update any other callers of validate_component (the second occurrence noted in the review) to use the new enum and adjust error messages to reference the Component variants.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/state/src/database.rs`:
- Around line 512-523: The code uses validate_component(&str) with string
literals and a catch-all path; change validate_component to accept a typed enum
(e.g., enum Component { ProjectId, PhpTrack, Name, Track }) and update all call
sites in the PortIdentity match arms (the Self::Project and Self::Resource
branches) to pass the appropriate Component variant instead of string literals,
so validation is exhaustive at compile time and the impossible fallback can be
removed; also update any other callers of validate_component (the second
occurrence noted in the review) to use the new enum and adjust error messages to
reference the Component variants.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b38edac0-455f-4725-96f6-f3b1b223606b
⛔ Files ignored due to path filters (1)
crates/state/tests/snapshots/state_foundation__port_allocator_persists_reuses_avoids_collisions_and_releases_assignments.snapis excluded by!**/*.snap
📒 Files selected for processing (4)
crates/state/src/database.rscrates/state/src/error.rscrates/state/src/sql/001_core_state_schema.sqlcrates/state/tests/state_foundation.rs
Contributor
Author
|
@codex Review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6cd4c9f7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced May 28, 2026
This was referenced Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roadmap
Implements PR 5: PV-030, PV-031, PV-032, PV-033, PV-034, PV-035, PV-036.
Verification
Summary by CodeRabbit
New Features
Bug Fixes / Improvements
Tests