PFS - Fixed faulty logic behind bitmap-management, readlink and attribute IOCTL2 calls#68
Merged
Conversation
…on issue. When working with 32-bit words (divide index by 32 instead of 8), the index may become truncated. Hence work with bytes instead, as per the original.
…corrected typo in function name (loopup -> lookup) and replaced more hardcoded values with defines. Note: readlink() currently does not work with fileXio, as the RPC server is bugged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic behind the Bitmap-management functions was always slightly different in ours, compared to the original.
Recent logs from HDDChecker have shown that PFS may be unable to correctly update the volume bitmap. Perhaps it is due to the homebrew module dividing the index by 32 (instead of 8), before it is left-shifted by 2. As a result, 2 bits of the index will be lost.
Readlink had a faulty check around whether the inode is a symbolic link or not. However, this function still cannot be correctly used from the EE, since fileXio's RPC server does not correctly support readlink().
The IOCTL2 commands for attributes had faulty logic around the main loop corrected.