iop: default srxfixup flags & allow zero-.text for non-exporting modules#817
Merged
uyjulian merged 1 commit intops2dev:masterfrom Mar 6, 2026
Merged
Conversation
Member
|
May I suggest, for backwards compatibility ifneq (,$(filter $(IOP_OBJS_DIR)exports.o,$(IOP_OBJS)))
IOP_OBJS := $(IOP_OBJS_DIR)exports.o $(filter-out $(IOP_OBJS_DIR)exports.o,$(IOP_OBJS))
endif |
Default IOP_SRXFIXUP_FLAGS to --rb --irx1 and use it for the iopfixup invocation. When the build does not produce exports.o, append --allow-zero-text so modules without an export table do not fail the zero-.text check. This keeps behavior consistent with iop/Rules.make while allowing top-level Makefiles to override IOP_SRXFIXUP_FLAGS when needed.
fjtrujy
force-pushed
the
srxfixup_zero_text_dectection
branch
from
05d9356 to
916edea
Compare
uyjulian
added a commit
to uyjulian/Open-PS2-Loader
that referenced
this pull request
Mar 6, 2026
5 tasks
uyjulian
added a commit
to uyjulian/Open-PS2-Loader
that referenced
this pull request
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default IOP_SRXFIXUP_FLAGS to --rb --irx1 and use it for the iopfixup invocation. When the build does not produce exports.o, append --allow-zero-text so modules without an export table do not fail the zero-.text check. This keeps behavior consistent with iop/Rules.make while allowing top-level Makefiles to override IOP_SRXFIXUP_FLAGS when needed.