Use script for config downloads#138
Conversation
Per previous PR and branch, use `get-config-scripts.sh` to get configs instead of manually `wget` from Savannah. Ensures overarching logic matches and has local fallbacks if Savannah is unreachable.
|
LGTM. But just so you know: By placing |
|
I think we ought to move it somewhere more appropriate in that case. Beside the local copies of config, or do you have another suggestion? |
|
Well, having the three files in the same dir is fine, but then I don't think it should be called |
| chmod +x "${file}" | ||
| } | ||
|
|
||
| fetch_config_file config.guess |
There was a problem hiding this comment.
Please wrap these for CI purposes
if [ -z "${NO_SAVANNAH}" ]; then
fetch_config_file config.guess
fetch_config_file config.sub
else
echo "NO_SAVANNAH is set, skipping Savannah downloads."
cp "${ASSET_DIR}/config.guess" "config.guess"
cp "${ASSET_DIR}/config.sub" "config.sub"
fi
Rename `assets` directory to `config` and contained within this, the GNU `config` files and our helper script. Done per feedback to avoid this running at the end of regular execution.
c302565 to
39da9fa
Compare
|
@zeldin Agreed with the suggestion. They're now grouped in the |
Per previous PR #137 and branch
config-refactor, useget-config-scripts.shto get configs instead of manuallywgetfrom Savannah. Ensures overarching logic matches and has local fallbacks if Savannah is unreachable.Cleaned up the noise and removed any orthogonal elements.