Update pre-commit config#2331
Merged
Merged
Conversation
via `pre-commit autoupdate` ``` Updating https://gitlab.com/pycqa/flake8 ... updating 3.9.0 -> 3.9.2. Updating https://github.com/pre-commit/mirrors-mypy ... updating v0.812 -> v0.902. Updating https://github.com/pre-commit/mirrors-prettier ... updating v2.2.1 -> v2.3.1. ``` Signed-off-by: SADIK KUZU <sadikkuzu@hotmail.com>
JelleZijlstra
added
the
ci: skip news
| flake8 = "*" | ||
| flake8-bugbear = "*" | ||
| mypy = ">=0.812" | ||
| types-dataclasses = ">=0.1.3" |
Collaborator
There was a problem hiding this comment.
This should only be needed <3.7, can we express that here?
Collaborator
There was a problem hiding this comment.
Good call, will do that since IIRC it's possible.
Collaborator
There was a problem hiding this comment.
For the record, this is actually not possible due to python_version=3.6 in mypy.ini.
Collaborator
|
Sorry for not updating until now. Your PR was mostly A-OK to land except for the fact that mypy 0.9XX introduces modular typeshed which means we need to pull in a few Thanks for the PR! |
Contributor
Author
|
Maybe this can help: https://twitter.com/pre_commit_ci/status/1404525673100705794 |
... due to `python_version=3.6` in mypy.ini.
JelleZijlstra
approved these changes
Jun 22, 2021
Contributor
Author
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update pre-commit config
via
pre-commit autoupdate