remove duplicate syms.for_stmt entry - #5278
Merged
cobaltt7 merged 1 commit intoAug 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant duplicate entry in linegen.py where syms.for_stmt appeared twice in the parent-type allowlist used to preserve parentheses around walrus assignments. This is a small cleanup that keeps the logic unchanged while improving readability/maintainability.
Changes:
- Remove the duplicate
syms.for_stmtentry from theparent.type in [...]check insidemaybe_make_parens_invisible_in_atom.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syms.for_stmtappears twice in the list of parent types where walrus-assignment parentheses are kept. The duplicate is harmless (set membership is unaffected) but serves no purpose; drop it to keep the list tidy.