Skip to content

Fix indent calculation with tabs when computing prefixes - #595

Merged
JelleZijlstra merged 1 commit into
psf:masterfrom
sciyoshi:dedent-fix
Feb 5, 2019
Merged

Fix indent calculation with tabs when computing prefixes#595
JelleZijlstra merged 1 commit into
psf:masterfrom
sciyoshi:dedent-fix

Conversation

@sciyoshi

@sciyoshi sciyoshi commented Nov 6, 2018

Copy link
Copy Markdown
Contributor

Closes #262, bug seems to have been introduced in 54d707e. Indent widths in lib2to3 for tabs are actually counted as 1, not 4, so consuming the prefix needs to match that.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 792

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.15%

Totals Coverage Status
Change from base Build 791: 0.04%
Covered Lines: 2922
Relevant Lines: 3039

💛 - Coveralls

@coveralls

coveralls commented Nov 6, 2018

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 810

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.106%

Totals Coverage Status
Change from base Build 791: 0.0%
Covered Lines: 2912
Relevant Lines: 3030

💛 - Coveralls

@JelleZijlstra

Copy link
Copy Markdown
Collaborator

Going to close and re-open to restart CI.

@JelleZijlstra
JelleZijlstra merged commit 66aa676 into psf:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indentation is incorrectly changed for tabulated comments after a dedent

3 participants