Move Ruff to pre-commit to pin it - #250
Merged
Merged
Conversation
Member
|
Merged, thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox -e pep8is failing in #248 and #249.This is because they run
ruff check, and Ruff has just released version 0.16 which increases the number of default rules from 59 to 413: https://astral.sh/blog/ruff-v0.16.0This PR moves the
ruff checkfrom tox to pre-commit, thereby pinning it, so we won't get any surprises outside explicit updates of this pin.I pinned it to the previous 0.15, because there will be a lot of changes to go to 0.16, and we can handle that in another PR, including deciding whether to ignore some rules.