Skip to content

One last Charade reference to remove here.#1901

Merged
Lukasa merged 1 commit into
psf:masterfrom
mjpieters:chardet-not-charade
Feb 4, 2014
Merged

One last Charade reference to remove here.#1901
Lukasa merged 1 commit into
psf:masterfrom
mjpieters:chardet-not-charade

Conversation

@mjpieters

Copy link
Copy Markdown
Contributor

No description provided.

@Lukasa

Lukasa commented Feb 3, 2014

Copy link
Copy Markdown
Member

This is an obvious 👍. =D

@sigmavirus24

Copy link
Copy Markdown
Contributor

This amounts to essentially a documentation change. I don't see why it shouldn't be merged immediately (or as soon as the build passes).

@Lukasa

Lukasa commented Feb 3, 2014

Copy link
Copy Markdown
Member

Looks like the CI server is having a tough time, I haven't seen any of these builds pass.

@sigmavirus24

Copy link
Copy Markdown
Contributor

It notifies people in IRC right? Freenode has been having some trouble since last night. It could be that the server is blocked trying to connect to IRC to notify of older jobs that have passed/failed.

@Lukasa

Lukasa commented Feb 4, 2014

Copy link
Copy Markdown
Member

Anyway, the build is an irrelevance here.

Lukasa added a commit that referenced this pull request Feb 4, 2014
One last Charade reference to remove here.
@Lukasa Lukasa merged commit 15ac4e5 into psf:master Feb 4, 2014
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants