Don't treat NewConnectionErrors as timeouts.#2812
Merged
sigmavirus24 merged 1 commit intopsf:masterfrom Oct 8, 2015
Merged
Conversation
This is a compatibility change, and should be removed in 2.8.0
sigmavirus24
added a commit
that referenced
this pull request
Oct 8, 2015
Don't treat NewConnectionErrors as timeouts.
Member
Author
|
@sigmavirus24 How do you feel about removing this in 3.0.0? |
Contributor
|
+0 |
|
@Lukasa I've found a TODO made by you and associated with this issue https://github.com/requests/requests/blob/3.0/requests/adapters.py#L531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2811.
Fundamentally I view this mostly as a compatibility change, to get us back into line with how we've processed this kind of error in the 2.X series. I think I'd like to back it out in 3.0.0, which is why I've left a note in the code to that effect.