Add warnings about text/binary mode files.#2825
Merged
sigmavirus24 merged 2 commits intopsf:masterfrom Oct 24, 2015
Merged
Conversation
Contributor
|
@Lukasa do we want to add that warning in |
Member
Author
|
@sigmavirus24 Yeah, probably. |
|
♥ thanks brosephs @sigmavirus24 @Lukasa |
Contributor
|
@Lukasa do you want me to send that separately or do you want to do that as part of this PR? |
Member
Author
|
Ah, I forgot about that. Let's do it here. |
Member
Author
|
Ok, I added a warning that should fire once the first time this happens (no need to spam the crap out of people with it). It's strictly a subclass of |
sigmavirus24
added a commit
that referenced
this pull request
Oct 24, 2015
Add warnings about text/binary mode files.
Contributor
|
Excellent work @Lukasa . Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2725.
@sigmavirus24 I'm wondering if we should add a warning to
super_lenfor whenever we decide on the length of the file usingos.fstat, if the file has not been opened in binary mode. It should be easy enough to do. Thoughts?