chore(config): trim comments, reconcile drift, drop deprecated brew tap - #11
Open
ptaranat wants to merge 2 commits into
Open
chore(config): trim comments, reconcile drift, drop deprecated brew tap#11ptaranat wants to merge 2 commits into
ptaranat wants to merge 2 commits into
Conversation
Homebrew deprecated and emptied this tap, so tapping it is now a hard error and brew bundle fails outright: Error: homebrew/services was deprecated. This tap is now empty brew services moved into brew core, so nothing is lost by removing it. This broke run_onchange_after_10-packages.sh on every apply.
Cut prose comments across 19 files, keeping a one-line reason wherever the 'why' was not obvious from the code. 736 -> 374 comment lines. Largest reduction is aerospace.toml (147 -> 14): almost all of it was upstream template boilerplate, including the 'All possible keys' reference block and 52 commented-out alt-a..alt-z bindings. Kept as one-liners: the brew --no-upgrade incident, the Ghostty pgrep truncation, the Helium single-instance handoff, /etc/zshrc clobbering history settings, and the p10k instant-prompt ordering constraint. Also folds two local-only changes back into the source, which had drifted because the tools write to deployed files directly: - mise lua 5.4 (installed for luarocks) - .gitconfig gh auth credential helper blocks The tmux truecolor config was the third such drift, but it turned out to already exist on fix/tmux-truecolor, so this branch is rebased onto that one and only retrims its comments. No functional lines changed beyond those two merges.
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ptaranat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(brew): drop deprecated homebrew/services tap
Homebrew deprecated and emptied this tap, so tapping it is now a hard
error and brew bundle fails outright:
Error: homebrew/services was deprecated. This tap is now empty
brew services moved into brew core, so nothing is lost by removing it.
This broke run_onchange_after_10-packages.sh on every apply.
chore(config): trim comments and reconcile drift
Cut prose comments across 19 files, keeping a one-line reason wherever
the 'why' was not obvious from the code. 736 -> 374 comment lines.
Largest reduction is aerospace.toml (147 -> 14): almost all of it was
upstream template boilerplate, including the 'All possible keys'
reference block and 52 commented-out alt-a..alt-z bindings.
Kept as one-liners: the brew --no-upgrade incident, the Ghostty pgrep
truncation, the Helium single-instance handoff, /etc/zshrc clobbering
history settings, and the p10k instant-prompt ordering constraint.
Also folds two local-only changes back into the source, which had
drifted because the tools write to deployed files directly:
The tmux truecolor config was the third such drift, but it turned out
to already exist on fix/tmux-truecolor, so this branch is rebased onto
that one and only retrims its comments.
No functional lines changed beyond those two merges.