Skip to content

[CMAKE] Remove the trailing '/' from INSTALL_PATH - #4015

Merged
ptitSeb merged 1 commit into
ptitSeb:mainfrom
zengdage:install-path
Jul 8, 2026
Merged

[CMAKE] Remove the trailing '/' from INSTALL_PATH#4015
ptitSeb merged 1 commit into
ptitSeb:mainfrom
zengdage:install-path

Conversation

@zengdage

@zengdage zengdage commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Remove the trailing '/' from INSTALL_PATH, otherwise an extra slash will be generated when installing directories.

Just fix typo.

BTW, I am working on supporting collaborative meeting software with screen sharing functionality, which requires emulated support for libpipewire-0.3 and libspa-0.2.

Would it be acceptable to upload roughly 50 libraries(ibpipewire-0.3 and libspa-0.2)into x64lib? If not, what are the criteria for libraries allowed to be uploaded into x64lib?

Otherwise an extra slash will be generated when installing directories.
@ptitSeb

ptitSeb commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Uploading 50 libraries directly doesn't sound like a good idea. I know that wrapping libpipewire is tricky but that would still be the ideal solution tbh.
In the mean time, maybe try to look at the bundle instead. @LukeShortCloud your thought aabout that?

@ptitSeb
ptitSeb merged commit 17b0ca1 into ptitSeb:main Jul 8, 2026
28 checks passed
@LukeShortCloud

Copy link
Copy Markdown
Collaborator

That's a lot of libraries! Yeah, adding these to the bundle would be the best place. The long-term goal is to remove the x86lib and x64lib binaries from the git repository. Instead, the bundle is uploaded to each GitHub release.

@zengdage you can look here from some hints on how to find and add new libraries using system packages:

I can also help.

Do you have a full list of what those ~50 libraries are? It might only be a few packages we need to add to the CSV file.

@zengdage

zengdage commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

That's a lot of libraries! Yeah, adding these to the bundle would be the best place. The long-term goal is to remove the x86lib and x64lib binaries from the git repository. Instead, the bundle is uploaded to each GitHub release.

@zengdage you can look here from some hints on how to find and add new libraries using system packages:

I can also help.

Do you have a full list of what those ~50 libraries are? It might only be a few packages we need to add to the CSV file.

I'll first take a look at the bundle mechanism.

Not all of these libraries may actually be required, they are simply bundled within the same package. libs list:

libpipewire-0.3.so.0
pipewire-0.3/libpipewire-module-access.so
pipewire-0.3/libpipewire-module-adapter.so
pipewire-0.3/libpipewire-module-client-device.so
pipewire-0.3/libpipewire-module-client-node.so
pipewire-0.3/libpipewire-module-echo-cancel.so
pipewire-0.3/libpipewire-module-fallback-sink.so
pipewire-0.3/libpipewire-module-filter-chain.so
pipewire-0.3/libpipewire-module-link-factory.so
pipewire-0.3/libpipewire-module-loopback.so
pipewire-0.3/libpipewire-module-metadata.so
pipewire-0.3/libpipewire-module-portal.so
pipewire-0.3/libpipewire-module-profiler.so
pipewire-0.3/libpipewire-module-protocol-native.so
pipewire-0.3/libpipewire-module-protocol-pulse.so
pipewire-0.3/libpipewire-module-protocol-simple.so
pipewire-0.3/libpipewire-module-pulse-tunnel.so
pipewire-0.3/libpipewire-module-raop-discover.so
pipewire-0.3/libpipewire-module-raop-sink.so
pipewire-0.3/libpipewire-module-rt.so
pipewire-0.3/libpipewire-module-rtkit.so
pipewire-0.3/libpipewire-module-session-manager.so
pipewire-0.3/libpipewire-module-spa-device-factory.so
pipewire-0.3/libpipewire-module-spa-device.so
pipewire-0.3/libpipewire-module-spa-node-factory.so
pipewire-0.3/libpipewire-module-spa-node.so
pipewire-0.3/libpipewire-module-x11-bell.so
pipewire-0.3/libpipewire-module-zeroconf-discover.so
pipewire-0.3/v4l2/libpw-v4l2.so
spa-0.2/aec/libspa-aec-null.so
spa-0.2/aec/libspa-aec-webrtc.so
spa-0.2/alsa/libspa-alsa.so
spa-0.2/audioconvert/libspa-audioconvert.so
spa-0.2/audiomixer/libspa-audiomixer.so
spa-0.2/audiotestsrc/libspa-audiotestsrc.so
spa-0.2/control/libspa-control.so
spa-0.2/support/libspa-dbus.so
spa-0.2/support/libspa-journal.so
spa-0.2/support/libspa-support.so
spa-0.2/test/libspa-test.so
spa-0.2/v4l2/libspa-v4l2.so
spa-0.2/videoconvert/libspa-videoconvert.so
spa-0.2/videotestsrc/libspa-videotestsrc.so
spa-0.2/volume/libspa-volume.so

@zengdage
zengdage deleted the install-path branch July 9, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants