[RV64_DYNAREC] Fix HADDPS NaN issue - #4149
Merged
Merged
Conversation
RISC‑V floating‑point operations produce a default quiet‑NaN of 0x7fc00000, while x86‑64 defaults to 0xffc00000.
ptitSeb
reviewed
Jul 29, 2026
ptitSeb
reviewed
Jul 29, 2026
ptitSeb
reviewed
Jul 29, 2026
ptitSeb
reviewed
Jul 29, 2026
Contributor
Author
|
@ptitSeb BTW, I noticed that some compilation warnings are generated when building Box64. Would you accept a PR that addresses these warnings? |
Owner
Sure, but I'll merge this kind of PR after the release of 0.4.4 (also, those kind of PR can be more tricky than expected... and break things in the process) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RISC‑V floating‑point operations produce a default quiet‑NaN of 0x7fc00000, while x86‑64 defaults to 0xffc00000. So need NaN handleing.