[SIGNAL] Preserve TF handling when resuming signals with Dynarec - #4174
Merged
Conversation
When a signal handler restores a context with TF set, resume through the interpreter for one instruction so no_tf can suppress the initial spurious SIGTRAP. This fixes the issue exposed after commit 38d64ba when running Syringe.exe from the Ares expansion platform.
Mikura-Kyouka
marked this pull request as ready for review
August 2, 2026 05:54
Collaborator
|
Why not just revert 38d64ba? |
Collaborator
ksco
approved these changes
Aug 2, 2026
ksco
left a comment
ksco
left a comment
Collaborator
There was a problem hiding this comment.
PR looks legit to me, but maybe we should just revert the offending commit.
Owner
|
Well, commit 38d64ba should bring some slight speedup for regular signal handling, especialy for DRM that use a lot of segfault, so I prefer to use that PR instead of reversing the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a signal handler restores a context with TF set, resume through the interpreter for one instruction so no_tf can suppress the initial spurious SIGTRAP.
This fixes the issue exposed after commit 38d64ba when running Syringe.exe from the Ares expansion platform.