[LA64_DYNAREC] Speed up crc validation - #4178
Merged
Merged
Conversation
Collaborator
Author
|
This is only slightly slower than the exact match method, which is good enough. |
Owner
|
Well, the exact match will always be faster in case of mismatch... |
Collaborator
Author
|
No, it's more than that. Every iteration of the original 1-way CRC loop has a data dependency on the previous iteration, and CRC is quite slow. A multi-way CRC loop will cancel most of those dependencies. |
Owner
|
Oh, I see. The point is to avoid starving the pipeline with dependant load+crc pairs |
Collaborator
Author
|
For 12 elements, it's like v.s. |
Collaborator
Author
|
I tested 4-way, 6-way, 8-way, 6 way seems to be the best, but I guess that depends on the hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.