Document the branch-deletion CI guard#215
Merged
Merged
Conversation
The PR workflow's validate/smoke-build/aggregator carry a !github.event.deleted guard, but WORKFLOW.md said they run "unconditionally". Note the branch-deletion exception in the architecture section, D1.1, and the 5A audit, and add scenario S16. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI/CD architecture documentation to accurately describe why validate, smoke-build, and the required aggregator do not run on branch-deletion push events (they are guarded by !github.event.deleted because github.sha is all-zeros and checkout/build would fail). This aligns WORKFLOW.md with the actual behavior in the PR workflow.
Changes:
- Document the branch-deletion (
github.event.deleted) guard as the one exception to “run on every push” for PR validation jobs. - Clarify D1.1 and the 5A audit checklist to account for branch-deletion pushes and the aggregator being skipped to avoid a pending required check.
- Add test scenario S16 covering branch deletion behavior.
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORKFLOW.md said validate/smoke-build run unconditionally, but they carry a
!github.event.deletedguard. Note the branch-deletion exception in the architecture section, D1.1, and the 5A audit, and add scenario S16. Follow-up to #211/#212.