Conversation
Consolidation of two fixes surfaced during the Utilities review that also apply here: - **jq_lacks exit-4 bug:** `jq -e` exits 4 (not 1) when a filter yields no output, so the "main does not require linear history" assert (jq_lacks on a correctly-absent rule -> exit 4) failed on a correct ruleset. Treat exit 1 and 4 as "lacks"; propagate real jq errors (2/3/5). Verified under `set -euo pipefail`. - **App-install README wording:** `check_app` only *notes* (best-effort) whether a GitHub App is installed; the README said the script "asserts" it. Separate the assert (secret names) from the note. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes a small repo-config maintenance fix: it corrects jq_lacks to treat jq -e exit code 4 (no output) as “lacks”, and clarifies documentation around the GitHub App installation check being best-effort rather than an assertion.
Changes:
- Update
jq_lacksto treatjq -eexit codes1and4as “lacks”, while still propagating real jq errors. - Clarify
repo-config/README.mdwording so the App-installation check is described as best-effort and non-failing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| repo-config/configure.sh | Fixes jq_lacks semantics so ruleset checks don’t fail on correct “no match” conditions (jq exit 4). |
| repo-config/README.md | Updates documentation to accurately describe the App-installation check as informational (non-asserting). |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #219: jq_lacks now treats jq exit 4 (no output) as 'lacks' so configure.sh check passes on a correct main ruleset; repo-config README clarifies the App-install note (best-effort, not asserted). No library code change.