Skip to content

Promote: keep jq stderr in jq_lacks#222

Merged
ptr727 merged 1 commit into
mainfrom
develop
Jun 29, 2026
Merged

Promote: keep jq stderr in jq_lacks#222
ptr727 merged 1 commit into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Promotes the develop consolidation to main: jq_lacks discards only stdout (drops 2>&1) so a real jq error (exit 2/3/5) prints its diagnostic while the no-output/false cases (exit 1/4) stay silent. Converges repo-config/configure.sh with the other repos.

No-bypass promotion via merge commit.

Discard only stdout in `jq_lacks` (drop `2>&1`). jq's exit 0/1/4 cases
produce no stderr so normal audit runs stay silent, but a real jq error
(exit 2/3/5) now prints its diagnostic instead of failing silently.

Converges `repo-config/configure.sh` with the Docker repos
(PlexCleaner/VSCode-Server), where Copilot surfaced this. Verified:
`bash -n`, shellcheck, and the lacks/match cases still behave with no
spurious stderr.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 29, 2026 05:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This promotion updates the repo configuration script’s jq_lacks helper to keep jq error diagnostics visible on stderr while still discarding stdout, so real jq failures are actionable without adding noise for “no match / no output” cases.

Changes:

  • Update jq_lacks to discard only stdout (remove 2>&1) so jq diagnostics remain visible.
  • Update the adjacent comment to document the stdout-only discard behavior.

@ptr727 ptr727 merged commit 992664c into main Jun 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants