Add the global editorconfig CRLF default#242
Merged
Merged
Conversation
Set end_of_line = crlf on the [*] block so every file type has a defined ending, matching the fleet template. Per-type CRLF rules and .gitattributes LF pins unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request standardizes line-ending governance by setting a repository-wide default of end_of_line = crlf in the .editorconfig [*] section, so all file types have an explicit baseline line-ending policy while preserving existing per-pattern overrides (e.g., *.sh and Dockerfiles remain lf).
Changes:
- Add
end_of_line = crlfto the.editorconfigglobal[*]defaults block. - Keep existing per-file-type overrides intact (notably
*.shand Dockerfiles pinned tolf).
The global [*] end_of_line = crlf also matches the extensionless .husky/pre-commit hook (must stay LF) and the downloaded LanguageData/* files (a mix of LF/CRLF that must persist byte-for-byte). Add an LF override for the hook (aligned with .gitattributes) and end_of_line = unset for LanguageData so the editor does not normalize the source data. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
The [*] defaults (insert_final_newline, trim_trailing_whitespace, charset) still applied to the downloaded LanguageData/* files after only unsetting end_of_line, and any of them can mutate byte-sensitive source data. Unset charset/end_of_line and set insert_final_newline/trim_trailing_whitespace = false so the editor preserves the source bytes exactly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Move the LanguageData/* byte-preservation block above the '.NET-only below' separator, alongside the other line-ending rules, instead of at the file end in the .NET-style section. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
end_of_line = crlfto the.editorconfig[*]block so every file type has a defined ending (matching the fleet template) instead of the per-extension-only form. Per-type CRLF rules and.gitattributesLF pins unchanged.Resolves the recurring line-ending drift from the ProjectTemplate audit (
reports/languagetags/audit.md), via the audit convergence pattern (AUDIT.mdsection 10).🤖 Generated with Claude Code