Match the whole LanguageData tree in the editorconfig byte-preserve rule#244
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s EditorConfig rules so the “byte-preserve” override applies to the entire downloaded language data tree, aligning editor behavior with the existing .gitattributes no-normalization contract for LanguageData/.
Changes:
- Change the EditorConfig section header from
[LanguageData/*]to[LanguageData/**]so subdirectories are included. - Ensure all downloaded data files under
LanguageData/avoid editor normalization (charset/EOL/final newline/trim).
The [LanguageData/*] section only matched files directly under LanguageData/, leaving the iso6392/, iso6393/, rfc5646/, and unm49/ subtrees without the no-normalization override. Use the recursive [LanguageData/**] glob so the override covers every downloaded data file, matching the * -text gitattributes contract. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ptr727
force-pushed
the
feature/languagedata-recursive-glob
branch
from
e47c262 to
cb7689a
Compare
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[LanguageData/*]section only matched files directly underLanguageData/, leaving theiso6392/,iso6393/,rfc5646/, andunm49/subtrees without the no-normalization override. Use the recursive[LanguageData/**]glob so the override covers every downloaded data file, matching the* -textgitattributes contract.Surfaced by the develop->main promotion review (#243).