Restore version floor to 2.13 - #437
Merged
Merged
Conversation
The 2.13 release chore inadvertently bumped version.json to 2.14; the next-cycle bump is a separate post-release step. Keep the floor at 2.13 for this release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Restores the Nerdbank.GitVersioning version floor in version.json back to 2.13 to match the documented 2.13 release (README/HISTORY), deferring any next-cycle bump to a separate post-release step per the repo’s versioning workflow.
Changes:
- Changed the NBGV
versionfloor from2.14back to2.13.
ptr727
added a commit
that referenced
this pull request
Jun 19, 2026
Promotes `develop` to `main` for the **2.13** release. ## Headline fix CodeGen was failing with SIGABRT (exit 134) — `ReleaseVersionForward` created duplicate version rows when an online *Latest* regressed below a version already present as *Stable*. Now folds the restored label into the existing entry, with an all-build `VerifyNoDuplicateVersions()` guard before the version file is written, defensive vendor-JSON parsing (reject conflicting publication types, fold benign duplicates), descriptive failure messages, and regression tests (#436, #437). ## Also included (already on develop) - Dependency bumps (#431, #432, #435) and codegen refreshes (#427, #428). - Versioning policy doc (#424) — note: the auto-bump rule is considered flawed and will be reconciled separately in #418. ## Versioning `version.json` is **2.13** (matches README/HISTORY release notes). The flawed per-release auto-bump rule is intentionally not applied. ## Notes Merging to `main` does not publish; the next scheduled publish picks it up. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: ptr727-codegen[bot] <275599072+ptr727-codegen[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ptr727
added a commit
that referenced
this pull request
Aug 30, 2026
The last audit class: eleven `readme-structure` findings. Audit run `2026-08-30T03:26:30Z | hub a378121`. Stacked on #551, so this PR is based on `resync/docs-split` and will retarget as its parents merge. ## The eleven findings | Finding | Fix | | --- | --- | | H1 is not the repo name | `# NxWitness` | | Tagline carries Markdown links | Link-free plain text, one sentence, 72 chars. The original sentence survives as the free prose below it, where links are allowed. | | No `## Questions or Issues` | Added. Carries the support routing moved out of `## Troubleshooting`, which keeps its own subsections. | | No `## 3rd Party Tools` | Added. The fleet's fixed lead line, then 23 entries alphabetized. | | No `### Releases` | Added under Build and Distribution, with the base class's GitHub release and pre-release shields plus the 40 Docker version shields moved up from the old `## Releases`. | | `[license-link]` points at a repo path | `[license]`, bare, since an in-repo path takes no suffix. | | Ten `[hub<name>-link]` references | Renamed to `<target>-docker-hub-link`, the shape that covers a repo shipping one image and one shipping ten. | | 161 definitions ungrouped | Grouped under the five declared headers in spec order, sorted by label within each. | The tagline is also mirrored into `HISTORY.md`, which the spec requires and which the old pair could never satisfy at once, since the shared sentence carried a Markdown link. Its now-orphaned `networkoptix-link` definition goes with it. For the tool list, every tool the hub catalogs uses the catalog's link and description verbatim; the rest are described as what the tool is rather than as what this repo does with it. ## Defects found while restructuring - The NxGo-LSIO install bullet linked the **Nx Witness** LSIO image. - The Products list linked **Wisenet WAVE** at `dwspectrum.com`. - A display filename read `Test.yaml` where the file is `Test.yml`. - `./LSIO/etc/s6-overlay/s6-rc.d/init-nx-relocate/run` resolved to nothing. Fixing the README alone would have been a symptom fix: `CreateMatrix/Dockerfile.cs` emits that comment into every LSIO Dockerfile, so the next codegen run reproduces it. The generator and the five generated files now name `Docker/s6-overlay/...`. Those files carry only that comment change; the upstream version bump a full regeneration also produces belongs to the codegen bot. - `Docker/README.md`, the Docker Hub overview, still opened with the retired title and tagline, so it disagreed with every other surface about the project's name. - A spaced hyphen joining two clauses, which the character-set rule bans in the same terms as an em dash. ## A correction to #549's stated verification `OPERATIONS.md` asserted that the local test command is plain `dotnet test`. That is unverified and false on at least one machine: a pristine checkout of the migration commit reports `Zero tests ran` and exit 5 there, while CI runs the same command on the same SDK (10.0.400, runtime 10.0.11) and reports 21 passed. My earlier local "21/21" came from a build tree still carrying state from the coverlet configuration it replaced. The configuration is correct, and CI is the evidence. The runbook now states the invocation CI actually runs as the one to reproduce locally, says that an MTP run discovering nothing exits 5 rather than passing silently so the count is what to read, and names the direct `dotnet CreateMatrixTests/bin/Debug/net10.0/CreateMatrixTests.dll` run as the way to separate a driver problem from a test-project problem. The `net10.0` versus `net10.0|x64` target string is the tell. Filed upstream as ptr727/ProjectTemplate#1122, since D1.6 governs this for the whole fleet and the remaining dotnet repos will hit it. ## Verification - Every label has a definition and every definition is used, 161 of 161, no duplicates. Every relative target exists, every in-page anchor resolves, the five group headers appear in spec order with labels sorted within each. - The Table of Contents matches the actual headings one for one, in order. - The ten image names match `Make/Matrix.json`; the base images match the two base Dockerfiles. - Build clean, markdownlint (48 files), cspell, editorconfig-checker and actionlint clean, no new cspell word needed. ## The 2.15 release is now documented This started as "reported, not fixed", and changed after the maintainer ruled on it. Recording the sequence, because the PR title does not suggest a release-notes change. `version.json` has declared 2.15 since 2026-06-29 and releases 2.15.43 through 2.15.59 have published since 2026-07-27, but neither `HISTORY.md` nor the README's Release Notes ever gained an entry, so both still described 2.14 as current. The bump came from #461, a large CI/CD migration that listed `version floor 2.14 -> 2.15` as one line item and added no changelog entry. The entry is derived rather than invented. Reading every merge between the 2.14 entry and now, 2.15 is the branch-scoped triggered-Docker CI/CD migration, the Codecov upload, multi-arch on `main` only, the lint-architecture standardization, and workflow hygiene. Nothing in it changes a published image, and the entry says exactly that rather than dressing infrastructure work up as a product release: ```text - Version 2.15: - Build, CI, and repository tooling changes only. No functional change to the published images. ``` **The floor is not rolled back**, per the maintainer: forward only once a release is cut. That is also the only mechanically safe answer, since NBGV derives the patch from git height, so a lower floor would generate versions sorting below what is already published. #437 could revert a bump cleanly because nothing had shipped at it; that window is closed here. The wider question, that agents have moved this repo's floor five times under a develop-leads-main cadence the fleet has since retired, is filed as ptr727/ProjectTemplate#1124 rather than addressed here. ## Reported, not fixed - The GitHub About description still carries the retired sentence. It feeds the Docker Hub short description through the docker-readme task, so that surface will disagree with the README until it is set by hand. `registry/repos.json` declares no `description` for this repo, so `configure.sh apply` cannot write it. - `HISTORY.md`'s 2.11 entry carries a lowercase `docker` in prose. It is a shipped changelog record rather than current prose, so it was left rather than edited for casing. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Expanded setup, installation, image variants, release channels, publishing, build workflows, troubleshooting, and support guidance. * Clarified supported NxWitness and OEM-branded VMS products. * Added testing, diagnostics, architecture checks, and coverage instructions. * Updated release history for version 2.15, corrected links, and removed an obsolete reference. * **Chores** * Updated documentation references for relocated runtime initialization paths. * Improved spell-check dictionary consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.13 release chore (merged in #436) bumped
version.jsonto 2.14, but this release ships as 2.13 (see README/HISTORY). The next-cycle bump to 2.14 is a separate post-release step per AGENTS.md versioning, so restore the floor to 2.13.Only
version.jsonchanges; no image files, so no smoke build.