Skip to content

operational-vs-release-workflow names the changes-detection job as the required check, and the aggregator is #1244

Description

@ptr727

The Publishing (release model) bullet in .agents/skills/operational-vs-release-workflow/SKILL.md reads:

The changes-detection job is a required check that must succeed, not just not fail. A paths-filter error must never let a target-changing PR merge with its smoke build silently skipped. A skipped smoke job (no matching change) passes, failure/cancelled blocks.

The behavior described in the second and third sentences is D1.5's aggregator, not the changes job. WORKFLOW.md D1.5 puts the required check on "a single aggregator job" whose "name is ruleset-bound: the job name: and the ruleset context: are the same string", and GOVERNANCE.md "Workflow YAML Conventions" names that string, Check pull request workflow status job in test-pull-request.yml. The changes job is what the aggregator needs:, and it is not itself the ruleset-bound check.

A reader configuring a branch ruleset from this bullet binds the wrong context:, which is the one class of mistake D1.5 calls out as silently breaking required-check enforcement.

Found by a whole-unit canonical pass over that skill's other units. Deferred out of the pull request that fixed #1207: that change was authorized to touch this file's frontmatter description only, since it addressed the routing split between the two skills rather than this section.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions