Skip to content

backlog-burndown: a promotion fix dispatched as a worker has no claim comment and no Closes on promotion line #1280

Description

@ptr727

backlog-burndown "The Promotion Boundary" step 4 says of the one fix the freeze permits: "That pass is dispatched as a worker like any other". A worker like any other requires two things a promotion fix has no home for.

  • "Grouping and File Claims" requires "Record every claim on the issue itself, as a comment naming the predicted file set and the branch that holds it, before dispatching". A promotion fix answers a review finding on the promotion pull request, so it ordinarily has no issue to record a claim on. Step 5 nevertheless ranks its file claim above every other group's ("A promotion fix outranks any file claim"), so the claim it wins is the one claim the skill has no way to record.
  • "Dispatching a Worker" requires "The brief requires the Closes on promotion: line in the pull request body, listing exactly the issues this group fixes". A promotion fix ordinarily fixes no issue, so the line has no content, and "Assembling the Promotion Body" reads that line and nothing else.

Nothing says to update the yielding holder's claim comment when the promotion fix takes the file either, which "Grouping and File Claims" otherwise requires "whenever the adjudication changes what a group holds, in either direction".

Reported as incomplete rather than guessed at: whether a promotion fix should get a synthetic claim record, or be exempted from both requirements, is a design call.

Raised by a local-strict-review carried-content pass on the pull request that added this skill, and deferred there under that skill's own review-round budget.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    decisionNeeds the maintainer's decision before it can be workedskillsAgent skill

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions