Skip to content

P0: Scope Reviewer Bots Away From Generated Mirrors and Bound What the Merge Gate Owes an Out-of-Diff Prose Finding #1314

Description

@ptr727

Part of #1311. Priority: now. One pull request plus a maintainer decision on bot configuration.

Why

Three reviewer bots run on every hub pull request, one of them on an assertive profile, and each comments on all three copies of every skill. PR #1291's Copilot review lists every suppressed finding three times. pr-review-conduct's Merge Gate item 3 then requires every finding on the head closed, including CodeRabbit's out-of-diff comments and Copilot's low-confidence collapsed findings, and outcome 4 files an issue for anything real and deferred. So a bot's remark on a sentence the diff never touched becomes an issue or a written decline, on every pull request, three times over. That is correct for code and is one of the pumps for prose.

Scope

  • Add path filters so reviewer bots skip .github/skills/** and .claude-plugin/**, which are byte-copies the build checks in CI. CodeRabbit and Qodo take a repository config file, and Copilot's exclusion is set in repository settings, so part of this is a maintainer action, listed as such.
  • Decide, and record in pr-review-conduct, which bots are required and which are advisory on prose paths. The maintainer's call. The recommendation is Copilot required everywhere, CodeRabbit and Qodo advisory on *.md under the canonical paths, with the assertive profile reserved for code.
  • Amend Merge Gate item 3 so that a finding on carried prose outside the diff is not dispositioned one at a time. The round batches them into one filed issue against the unit's tracker (the per-unit tracker issues are created by the triage sub-issue), replies once with its link, and moves on. Findings inside the diff keep the five outcomes unchanged.
  • Amend GOVERNANCE.md "Verification Discipline"'s "a review flags an instance, so fix the class" so the sweep is bounded to the files the diff already touches, and siblings elsewhere are filed to the tracker rather than folded into the diff.

Rules that bind this task

  • Nothing here lowers what a finding inside the diff owes. Every in-diff finding still ends in one of the five outcomes.
  • The Merge Gate stays the one enumeration of merge conditions. Change it in place rather than adding a second list elsewhere.
  • Regenerate the skill mirrors with python3 scripts/build_dist.py.

Acceptance

  • A pull request editing one skill draws bot comments on .agents/skills/ only.
  • A pull request whose only out-of-diff bot finding is on pre-existing prose reaches the Merge Gate with one tracker link in its thread, not one decline per finding.

Relates #1298, #1060, #1164, #1288.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agentsAgents instructionsproseA defect in rule or procedure textskillsAgent skill

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions