Conversation
Closes #1554. `reports/divergences.md` is written by `python3 spec/fidelity_honesty.py --report`, which joins the `spec/divergences.json` ledger against every cataloged repository's ground-truth branch through the GitHub API. It therefore goes stale as the fleet moves rather than as the hub is edited, and it is never hand-edited, per its own header. This pull request is that regeneration, plus one ledger edit a review finding on the regenerated diff asked for. The report is generated from the ledger, so a defect a regeneration exposes in a `reason` field is fixed in `spec/divergences.json` and regenerated rather than typed into the report. The two commits are: - `1992a92` regenerates `reports/divergences.md`, which is the whole of what #1554 asks for. - `27fe8e7` drops a stale carrier enumeration from the `run-codegen-pull-request-task.yml` retire reason in `spec/divergences.json`, and carries the regeneration that renders it. The row's header now reads the live carrier as NxWitness alone while the reason beside it still named LanguageTags too, and every sibling row that enumerates carriers dates the measurement that produced it, so it reads as a snapshot rather than as the current state. This row's did not. The enumeration is dropped rather than dated, since the row already renders the live list two clauses earlier and a second copy can only go stale again. ## The two rows the issue names | row | before | after | | --- | --- | --- | | `pyproject.toml` | `(tracking: #669)`, a closed issue | `(tracking: #1553)` | | `.markdownlint-cli2.jsonc`, Financial-Modeling | rendered as untriaged, no tracking value | no longer a live divergence, so it renders under Resolved | The second row settles differently from how the issue expected. Financial-Modeling's copy now matches the hub canonical byte for byte, verified independently of the run by fetching it and comparing against the hub's own file, so the row moves to the resolved section rather than gaining the `#1487` tracking value it was owed. The ledger entry carrying `#1487` is now a recorded divergence that is no longer live, which the resolved section says to remove from the ledger. That removal is a ledger edit and a separate change, per the generated-file rule this issue turns on. ## The rest of the diff The run reads whatever fleet drift has accumulated since the last regeneration, which is the reason the issue asked for it to land on its own. - **The retire rows shrink** where a resynced repository deleted its copy of a hub-hosted file. `repo-config/configure.sh` drops from eight carriers to four, and `repo-config/settings.json` from twelve to five. Spot-checked by asking the API for the file in four of the dropped repositories, each a 404. - **The mechanical re-vendor list grows** where a carried section moved on in the hub. `.markdownlint-cli2.jsonc` goes from eleven stale copies to seventeen, and four `GOVERNANCE.md` sections join the list. - **Three rows are new.** `spec/secrets.json` is now a live manifest gap under its recorded `retire` disposition. `PSScriptAnalyzerSettings.psd1` and `GOVERNANCE.md > Workflow YAML Conventions` are untriaged, so each needs a disposition added to the ledger, which is again a separate change. - **The AGENTS.md "not carried" lists shrink** as resynced repositories gained the sections, and those repositories move onto the stale list instead. ## Verification - `python3 spec/fidelity_honesty.py --report` ran to completion and wrote 77 lines. - The pre-commit gates ran on the commit: ruff format, ruff check, mypy, the prose gate, and the EOL check. `reports/` is a declared generated tree in the prose gate, so it is out of that gate's scope by design rather than silently skipped. - A local strict review pass is recorded over the diff, and the canonical gate reports no carried canonical unit changed.
Owner
Author
|
@coderabbitai review |
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are a straightforward ledger tweak plus a regenerated report, with only a minor wording-clarity suggestion outstanding.
Pull request overview
Promotes develop to main by carrying forward the regenerated fleet divergence report and its supporting ledger tweak, ensuring reports/divergences.md reflects current fleet state and updated tracking values.
Changes:
- Refresh
reports/divergences.mdfrom the currentspec/divergences.jsonledger and live fleet data. - Simplify the retire disposition reason for
run-codegen-pull-request-task.ymlto avoid stale carrier enumeration in the ledger.
File summaries
| File | Description |
|---|---|
| spec/divergences.json | Updates a retire-reason string to avoid embedding a carrier list that can go stale. |
| reports/divergences.md | Regenerates the divergence report to reflect current fleet reality and updated tracking. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote
developtomain.Closes #1554.
One change is being promoted, #1569, squashed onto
developasa3cd9c7.Regenerate reports/divergences.md Against the Current Fleet
reports/divergences.mdis written bypython3 spec/fidelity_honesty.py --report, which joins thespec/divergences.jsonledger against every cataloged repository's ground-truth branch through the GitHub API. It goes stale as the fleet moves rather than as the hub is edited, and it is never hand-edited, per its own header.Both rows #1554 names are settled. The
pyproject.tomlrow rendersptr727/ProjectTemplate#1553in place of the closed#669. The.markdownlint-cli2.jsoncFinancial-Modeling row is no longer a live divergence at all, its copy now matching the hub canonical byte for byte, so it renders under Resolved rather than gaining the#1487tracking value it was owed.The rest of the diff is accumulated fleet drift the run reads for the first time since the last regeneration, which is why #1554 asked for the regeneration to land on its own. Retire-row carrier lists shrink where a resynced repository deleted its copy of a hub-hosted file, the mechanical re-vendor list grows where a carried section moved on in the hub, and three rows are new:
spec/secrets.jsonis now a live manifest gap, whilePSScriptAnalyzerSettings.psd1andGOVERNANCE.md > Workflow YAML Conventionsare untriaged.The pull request also carries one ledger edit a review finding on the regenerated diff asked for: the
run-codegen-pull-request-task.ymlretire reason restated its carriers, and the restatement had gone stale against the live list rendered beside it. The enumeration is dropped at its source inspec/divergences.jsonand the report regenerated, rather than typed into the report.What This Leaves Open
Three follow-ups are ledger edits rather than regenerations, so each is its own change against the ledger: a disposition for each of the two untriaged rows, and removal of the now-resolved
.markdownlint-cli2.jsoncFinancial-Modeling entry, which#1487tracks.