Conversation
This PR updates the codegen files. Co-authored-by: ptr727-codegen[bot] <275599072+ptr727-codegen[bot]@users.noreply.github.com>
Closes #188 and #189. - #188: explicit four-precondition Merge Gate in AGENTS.md; CLEAN alone is never sufficient; condition 3 covers issue-level Copilot comments. - #189: prerelease guard strips +buildmetadata before the '-' test so SemVer2 build metadata can't false-reject a public release. - Comment hygiene: strengthened the AGENTS.md comment rule against verbosity creep and de-prosed over-grown comments across workflows, CodeGen, NuGetLibrary, and _version.py.
Contributor
There was a problem hiding this comment.
Pull request overview
Release promotion PR that merges the current develop head into main, carrying over the recent merge-gate hardening, prerelease guard fix, and comment-hygiene reductions, plus the latest codegen output update.
Changes:
- Add an explicit "Merge Gate" checklist to
AGENTS.mdand tighten comment brevity guidance. - Harden the
mainpublic-release prerelease guard by stripping SemVer2 build metadata before checking for a prerelease-. - Apply repo-wide comment de-prosing across workflows and source, and refresh the generated
CodeGen.cstimestamp.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PyPiLibrary/src/ptr727_projecttemplate_library/_version.py | Shorten versioning docstring while keeping hatchling/release-pipeline pointers. |
| NuGetLibrary/Library.cs | Remove redundant comments about lazy logger caching. |
| CodeGen/HttpClientFactory.cs | Trim/clarify comments around shared vs per-call HttpClient creation behavior. |
| CodeGen/CommandLine.cs | Shorten runtime-option rationale comment while preserving the determinism intent. |
| CodeGen/CodeGenBuilder.cs | Condense runtime determinism comment above codegen entrypoint. |
| CodeGen/CodeGen.cs | Update generated timestamp constant (codegen output refresh). |
| CodeGen/AssemblyInfo.cs | Clarify comment for ReleaseVersion extraction (core vs prerelease/build metadata). |
| AGENTS.md | Add explicit merge gate checklist; tighten comment hygiene rules. |
| .github/workflows/test-pull-request.yml | De-prose the changes job header comment. |
| .github/workflows/publish-release.yml | De-prose concurrency and dispatch-guard comments; keep behavior unchanged. |
| .github/workflows/merge-bot-pull-request.yml | De-prose header comment explaining auto-merge enable/disable behavior. |
| .github/workflows/check-upstream-version-task.yml | De-prose header and resolver validation comments. |
| .github/workflows/build-release-task.yml | Fix prerelease guard to ignore +buildmetadata when checking for -. |
| .github/workflows/build-pypilibrary-task.yml | De-prose the PEP 440 versioning comment before computing the version. |
| .github/workflows/build-executable-task.yml | De-prose restore-cache and artifact-upload comments. |
| .github/workflows/build-docker-task.yml | De-prose Docker login and cache-scoping comments. |
| .github/workflows/build-datebadge-task.yml | De-prose branch input rationale comment. |
A merge to main runs the publisher's no-op job only (PUBLISH_ON_MERGE off by default); publishing is the weekly schedule or manual dispatch. States it at the merge step so the two-phase Release Model isn't missed there, and bars triggering a publish without maintainer instruction. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
main's BuildNumber can exceed develop's briefly after a promotion, so note --pre "normally" prefers develop, with the transient exception. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the current
develophead tomainfor release.Contents:
Standard release promotion: merge (not squash) so develop's history carries to main.
🤖 Generated with Claude Code