lint: record VS Code config rule + rename EditorConfig step + process-type Lint tasks - #280
Merged
Merged
Conversation
…-type tasks - AGENTS.md: VS Code settings and extension recommendations live only in the .code-workspace, never a standalone .vscode/settings.json or .vscode/extensions.json (.vscode/ holds only tasks.json and launch.json). - Rename the "Check line endings" CI step and the "Lint: Line Endings" VS Code task to "EditorConfig" - the tool enforces charset, whitespace, and final-newline too, not just EOL. - VS Code Lint tasks: type: process with an args array instead of type: shell with a command string, for robustness and consistency with the rest of the tasks file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates governance and local/CI lint UX to better reflect what tools do and to make VS Code lint tasks more robust across shells/platforms.
Changes:
- Documented the fleet rule that VS Code settings/extension recommendations live only in the
.code-workspace(not.vscode/settings.jsonor.vscode/extensions.json). - Renamed the CI lint step (and the VS Code task) from "line endings" to "EditorConfig" to match
editorconfig-checker's actual scope. - Converted VS Code Lint tasks from
type: shell+ command string totype: process+argsarrays.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| catalog/snippets/configs/vscode-tasks.json | Renames the EditorConfig lint task and switches lint tasks to process + args for safer invocation. |
| AGENTS.md | Records the VS Code config location rule and updates lint-surface wording to "EditorConfig checks". |
| .github/workflows/test-pull-request.yml | Renames the editorconfig-checker step to "Check EditorConfig step" for accuracy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fleet conventions, canonical first (then I'll re-sync the converged repos).
.code-workspace, never a standalone.vscode/settings.jsonor.vscode/extensions.json(.vscode/holds onlytasks.jsonandlaunch.json). Recorded in the governance doc, not agent memory.Check line endingsCI step and theLint: Line EndingsVS Code task to EditorConfig — the tool enforces charset, trailing whitespace, and final-newline too, not just line endings.type: process+ args (fromtype: shell+ command string) for robustness (no shell-quoting) and consistency with the rest of the tasks file.Note: cspell model confirmed — the
.code-workspacealready recommends the Code Spell Checker extension (broad live hints on any file), while CI enforces README+HISTORY; nothing needed there.🤖 Generated with Claude Code