Correct repo-config README: App install is noted not asserted#353
Merged
Conversation
check_app only notes (best-effort) whether a GitHub App is installed - it does not fail the audit. The README said the script "asserts ... that a GitHub App is installed", contradicting WORKFLOW.md. Separate the two: it asserts the secret names exist, and notes the App install. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies repo-config documentation so it matches the actual configure.sh check_app behavior and WORKFLOW.md expectations: the script asserts required secret names, but only notes (best-effort) whether a GitHub App installation can be confirmed.
Changes:
- Update
repo-config/README.mdwording to separate “assert required secret names” from “note GitHub App installation (non-fatal)”. - Add rationale explaining why App installation cannot be asserted (requires app-level auth), so the audit does not fail on that check.
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repo-config README said the script 'asserts ... a GitHub App is installed', but check_app only notes it (best-effort, does not fail the audit) - inconsistent with WORKFLOW.md. Separate the assert (secret names) from the note (App install). Follow-up to #351/#352.