Conversation
Discard only stdout in `jq_lacks` (drop `2>&1`) and reflow the comment to the canonical wrapping. jq's exit 0/1/4 cases produce no stderr so normal audit runs stay silent, but a real jq error (exit 2/3/5) now prints its diagnostic instead of failing silently. Converges `repo-config/configure.sh` byte-for-byte with the other three repos, where Copilot surfaced this. Verified: `bash -n`, shellcheck. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the develop-side behavior of repo-config/configure.sh to main by adjusting jq_lacks so jq diagnostics are no longer suppressed on real jq failures, while keeping the “no match / false / null” cases silent. This supports the repo-configuration audit/apply tooling by making genuine jq errors actionable without increasing noise for expected “not present” checks.
Changes:
- Update
jq_lacksto discard only stdout (keep jq stderr visible) while preserving existing exit-code handling. - Reflow the
jq_lackscomment to the canonical wrapping and document the stdout/stderr intent.
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the
developconsolidation tomain:jq_lacksdiscards only stdout (drops2>&1) so a real jq error (exit 2/3/5) prints its diagnostic while the no-output/false cases (exit 1/4) stay silent. Comment reflowed to canonical wrapping. Convergesrepo-config/configure.shbyte-for-byte with the other repos.No-bypass promotion via merge commit.