Document the dotnet/nbgv @master no-SHA-pin rule#357
Merged
Conversation
nbgv already floats @master here; add the inline rationale comment and the AGENTS.md rule so the no-SHA-pin exception is explicit and converged across the fleet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR documents the repository’s explicit exception for using dotnet/nbgv@master (instead of SHA pinning), adding rationale both inline in the workflow and as a durable rule in AGENTS.md.
Changes:
- Add an
AGENTS.mdrule explicitly stating thedotnet/nbgv@masterno-SHA-pin exception. - Add an inline comment in
build-release-task.ymldocumenting why the action floats onmaster.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AGENTS.md | Adds a documented rule clarifying the dotnet/nbgv@master no-SHA-pin exception and rationale reference. |
| .github/workflows/build-release-task.yml | Adds inline workflow comment explaining why dotnet/nbgv is floated on master. |
Reword the inline comment and AGENTS note: nbgv's tag stream lags master, so Dependabot tag-tracking would only propose downgrades to stale tags (matching WORKFLOW.md D9.1 / lines 79-83), instead of the imprecise "a pin draws downgrades" phrasing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nbgv already floats
@masterhere; adds the inline rationale comment and theAGENTS.mdrule so the no-SHA-pin exception is explicit and converged fleet-wide. Doc-only; no behavior change.