Address filed configuration and doc defects#364
Merged
Conversation
- configure.sh: drop 2>/dev/null in check_security so gh's error surfaces (matches check_secrets). - WORKFLOW.md D7.2/section 2: reword so it no longer claims reusable tasks *declare* permissions (they run under the caller's least-privilege grant). Closes #359 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a small but important diagnostics gap in the repository configuration audit script and corrects/clarifies workflow documentation around reusable workflow permissions, aligning the docs with GitHub Actions’ caller-scoped permission model.
Changes:
repo-config/configure.sh: stop suppressinggh apistderr incheck_security()so auth/API failures surface clearly (matching the hardened behavior used elsewhere in the script).WORKFLOW.md: reword the reusable-workflow permissions guidance (section 2 and D7.2) to avoid implying the callee “declares” permissions, and instead reflect that the caller grants least-privilege permissions at theuses:job.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WORKFLOW.md | Clarifies reusable workflow permissions behavior and the “skipped jobs still need valid permissions” rule wording. |
| repo-config/configure.sh | Removes 2>/dev/null from the automated-security-fixes audit call so gh errors are visible and actionable. |
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359
Validation: shellcheck + actionlint + markdownlint clean; line endings preserved.
🤖 Generated with Claude Code