Skip to content

Declare workflow YAML as LF and validate line endings in CI#376

Merged
ptr727 merged 1 commit into
developfrom
feature/workflow-eol-lf
Jul 7, 2026
Merged

Declare workflow YAML as LF and validate line endings in CI#376
ptr727 merged 1 commit into
developfrom
feature/workflow-eol-lf

Conversation

@ptr727

@ptr727 ptr727 commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Dependabot and GitHub Actions rewrite workflow YAML with LF, so this declares LF for .github/workflows/*.{yml,yaml} in .editorconfig to keep it consistent instead of mixed on every bump. Non-workflow YAML stays CRLF.

  • .editorconfig: add the [.github/workflows/*.{yml,yaml}] end_of_line = lf section.
  • Convert the five workflow files to LF (EOL-only; content-neutral).
  • Add .editorconfig-checker.json (EOL-only checker config).
  • Add a Check line endings step (editorconfig-checker) to the lint job, right after actionlint.
  • AGENTS.md: note the workflow-YAML LF exception.

git still leaves endings alone (* -text); .editorconfig plus the CI editorconfig-checker step enforce the LF pin. Verified locally: editorconfig-checker clean, and git diff --ignore-cr-at-eol on the converted workflows is empty.

Dependabot and GitHub Actions rewrite workflow YAML with LF, so declare
LF for .github/workflows/*.{yml,yaml} in .editorconfig to keep it
consistent instead of mixed. Non-workflow YAML stays CRLF. git leaves
endings alone (* -text); a new editorconfig-checker step in the lint job
enforces it in CI, configured by .editorconfig-checker.json.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 6, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Standardizes GitHub Actions workflow YAML line endings to LF to prevent repeated churn from Dependabot / GitHub Actions rewrites, and adds CI enforcement to keep workflow EOLs consistent.

Changes:

  • Add an .editorconfig override pinning .github/workflows/*.{yml,yaml} to end_of_line = lf while keeping other YAML as CRLF.
  • Convert existing workflow files to LF (EOL-only) and document the workflow-YAML LF exception in AGENTS.md.
  • Add an editorconfig-checker config and a new lint step to validate line endings in CI.

Reviewed changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
AGENTS.md Documents the workflow-YAML LF exception in the repo’s line-ending guidance.
.editorconfig Pins workflow YAML to LF while leaving non-workflow YAML as CRLF.
.editorconfig-checker.json Adds editorconfig-checker configuration intended to make CI enforcement EOL-focused.
.github/workflows/validate-task.yml Adds a new lint step running editorconfig-checker (plus EOL-only conversion).
.github/workflows/test-pull-request.yml EOL-only conversion to LF for workflow consistency.
.github/workflows/publish-release.yml EOL-only conversion to LF for workflow consistency.
.github/workflows/merge-bot-pull-request.yml EOL-only conversion to LF for workflow consistency.
.github/workflows/build-release-task.yml EOL-only conversion to LF for workflow consistency.

Comment thread .editorconfig-checker.json
@ptr727 ptr727 merged commit 21ab3ab into develop Jul 7, 2026
10 checks passed
@ptr727 ptr727 deleted the feature/workflow-eol-lf branch July 7, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants