Add tests for non-primitive set operator HashMap paths to fix coverage regression#8
Merged
Merged
Conversation
Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
…e drop Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code test coverage issues
Add tests for non-primitive set operator HashMap paths to fix coverage regression
Mar 20, 2026
pubkey
marked this pull request as ready for review
March 20, 2026 13:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov project check fails because the ES2025 Set fast-path optimizations in
$setEquals/$setIsSubsetleft the HashMap fallback (non-primitive elements) untested, dropping project coverage from 99.59% → 99.50%.$setEquals: Added object-array tests covering the HashMap path for both equal (truevia line 44) and size-mismatch (falsevia line 42) cases$setIsSubset: Added object-array subset test triggering the early-termination branch (line 36)All existing tests used primitive values, so the native
Set.isSubsetOf()fast path was always taken. These four new cases force the HashMap codepath:Coverage after:
setEquals.ts85% → 100%,setIsSubset.tsbranch 90% → 100%.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.