Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
Coverage 35.58% 35.58%
=======================================
Files 102 102
Lines 1942 1942
Branches 297 297
=======================================
Hits 691 691
Misses 1251 1251 |
Member
Author
|
@jywarren @harshkhandeparkar please review!! |
Co-Authored-By: Divy123 <31225007+Divy123@users.noreply.github.com>
Member
Author
|
Thanks @harshkhandeparkar. Made the change!! |
Member
|
What if there are more than a single selectize selectors? Will there be more than a single |
Member
Author
|
It works successfully! I checked it locally. |
Member
Author
|
@harshkhandeparkar nice catch!! Just looking into it. Will make changes if required!! |
Member
Author
|
@harshkhandeparkar I think there is some error in that part which you said. Morning is my exam. I will see after 12 pm. |
Member
|
Np, exam is your priority. |
Member
Author
|
@jywarren please have a look!! |
Member
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1010
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!