Skip to content

Fixes threshold bug#1041

Merged
jywarren merged 4 commits intopubliclab:mainfrom
Divy123:fix-threshold-module
Apr 27, 2019
Merged

Fixes threshold bug#1041
jywarren merged 4 commits intopubliclab:mainfrom
Divy123:fix-threshold-module

Conversation

@Divy123
Copy link
Member

@Divy123 Divy123 commented Apr 25, 2019

Fixes #1010

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #1041 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files         102      102           
  Lines        1942     1942           
  Branches      297      297           
=======================================
  Hits          691      691           
  Misses       1251     1251

@Divy123
Copy link
Member Author

Divy123 commented Apr 25, 2019

@jywarren @harshkhandeparkar please review!!

Co-Authored-By: Divy123 <31225007+Divy123@users.noreply.github.com>
@Divy123
Copy link
Member Author

Divy123 commented Apr 25, 2019

Thanks @harshkhandeparkar. Made the change!!

@harshkhandeparkar
Copy link
Member

What if there are more than a single selectize selectors? Will there be more than a single .item?

@Divy123
Copy link
Member Author

Divy123 commented Apr 25, 2019

It works successfully! I checked it locally.

@Divy123
Copy link
Member Author

Divy123 commented Apr 25, 2019

@harshkhandeparkar nice catch!! Just looking into it. Will make changes if required!!

@Divy123
Copy link
Member Author

Divy123 commented Apr 25, 2019

@harshkhandeparkar I think there is some error in that part which you said. Morning is my exam. I will see after 12 pm.

@harshkhandeparkar
Copy link
Member

Np, exam is your priority.

@Divy123
Copy link
Member Author

Divy123 commented Apr 27, 2019

@jywarren please have a look!!
@harshkhandeparkar resolved that part !!

@jywarren jywarren merged commit 269215f into publiclab:main Apr 27, 2019
@jywarren
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

threshold throws error if used more than once consecutively

3 participants