Login modal edit wiki

[okonek]

Fixes #4242 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[okonek]

@SidharthBansal I think it works well.

[SidharthBansal]

Approved on the GCI dashboard

[okonek]

Thanks!

[plotsbot]

	2 Messages
📖	@okonek Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[SidharthBansal]

@okonek you have to click on the editor button once. Not twice. Please find a way such that you have to click on the button once.
click on button->login modal ->editing page

[SidharthBansal]

Looks good but we need to make it better so that the user needs to click on the button once.

[SidharthBansal]

@okonek can you please make your branch consistent with the current master and try out it again.
There might be some deletions and some additions in this pr too. Please send the changes whenever you get time. @kevinzluo and @JonathanXu1 proposed a solution in that pr so that we need to work less in other prs.

[SidharthBansal]

Hi, now we need to use requireLogin instead of the previous changes suggested by you @okonek
@okonek please do the required changes.
Thanks

[SidharthBansal]

@okonek are you stuck?
Need any help?

[SidharthBansal]

Closing this PR as requireLogin is created. These changes are no longer needed.
Thanks for your hardwork