History result refactor #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictionaries instead of plain objects
jakub-grzesiowski
requested review from
Xavrax,
marcin-cebo and
mohitpubnub
as code owners
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
approved these changes
Aug 29, 2025
src/Api/PubnubApi/Model/Consumer/History/PNHistoryItemResult.cs
Outdated
Show resolved
Hide resolved
* handle publish POST with secret key, calculate signature as old way * tests for signature calculation across all http method types * fix syntax error in test * use https in test * test-fix: removed unnecessary authtoken for secretKey test case for publish * test fix, removing invalid characters space from channel name --------- Co-authored-by: Mohit Tejani <mohit.tejani@Mohits-MacBook-Pro.local>
Contributor
Author
|
@pubnub-release-bot release as v7.5.0.0 |
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: change types of Meta and Actions in PNHistoryItemResult
Fixed types of Meta and Actions in PNHistoryItemResult to not be objects but properly formatted Dictionaries
fix: publish using POST type with token/secretKey failure.
Fixed issue of getting Forbidden error while using publish with POST type along with PAM enabled keyset