[hardware] fix integer reduction commit logic#439
Merged
Navaneeth-KunhiPurayil merged 1 commit intomainfrom Mar 13, 2026
Merged
[hardware] fix integer reduction commit logic#439Navaneeth-KunhiPurayil merged 1 commit intomainfrom
Navaneeth-KunhiPurayil merged 1 commit intomainfrom
Conversation
|
Hi navaneeth, this fix looks good to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue observed when we have back-to-back reduction operations. lane0 goes to the
SIMD_REDUCTIONstate and set'sresult_queue_valid_dto 1'b1 and setscommit_cnt_d= '0. This creates a problem if we have back-to-back reductions, since thealu_state_dswitches fromSIMD_REDUCTIONtoINTRA_LANE_REDUCTIONwithout staying inSIMD_REDUCTIONorNO_REDUCTIONstate for one more cycle for the commit to happen.Now, the
commit_cnt_dis set to '0 only after a successful commit to the VRF.Changelog
Fixed
Checklist
Please check our contributing guidelines before opening a Pull Request.