Only invalidate WRAP bursts if they are unmodifiable #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micprog
reviewed
Jul 1, 2025
niwis
approved these changes
Jul 1, 2025
Contributor
niwis
left a comment
niwis
left a comment
There was a problem hiding this comment.
LGTM. I think we may allow splitting non-modifiable wrapping bursts with a length greater than 16; at least I can't find a restriction to INCR bursts in issue K (A5.2.2)
Author
Hi Nils, if I understand the spec correctly the maximum length for WRAP bursts is 16 (A4.1.4). |
Contributor
|
Good point! Never mind, then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
axi_burst_unwrapmodule to only return a slave error if a WRAP burst transaction is marked unmodifiable; before, all unmodifiable transactions returned a slave error, even the ones that the module would not have modified.