fix(paths): Resolve env vars before applying prefix to dependency paths#303
Open
moshe-elastix wants to merge 1 commit intopulp-platform:masterfrom
Open
fix(paths): Resolve env vars before applying prefix to dependency paths#303moshe-elastix wants to merge 1 commit intopulp-platform:masterfrom
moshe-elastix wants to merge 1 commit intopulp-platform:masterfrom
Conversation
`PrefixPaths for String` was joining the consuming Bender.yml's parent
directory onto the raw template string before env vars were substituted, so a
`${VAR}` that expands to an absolute path was treated as a relative segment
and double-slashed (e.g. `<parent>//repo/...`). Direct absolute literals and
relative env vars worked; only absolute env-var expansions broke.
Substitute env vars first; skip the prefix when the substituted result is
already absolute, otherwise join as before.
Fixes pulp-platform#302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrefixPaths for Stringjoins the consuming Bender.yml's parent directory onto the raw template string before env vars are substituted, so a${VAR}that expands to an absolute path is treated as a relative segment and double-slashed (e.g.<parent>//repo/...). Direct absolute literals and relative env vars work; only absolute env-var expansions break.This PR fixes the issue by:
PrefixPaths for Stringbefore deciding whether to prefix.Fixes #302