Fix: parametrize CLUSTER_ALIAS in XBAR_PE#8
Merged
suehtamacv merged 1 commit intopulp-platform:masterfrom Feb 18, 2021
Merged
Conversation
suehtamacv
approved these changes
Feb 16, 2021
benoitdenkinger
added a commit
to HEP-SoC/cluster_interconnect
that referenced
this pull request
Aug 19, 2024
* riscof and sail support update. * bash script executed with bash instead of sh. * Added compile definition forwarding for riscof testsuite. * .text.vecs sections placed close to .text start. * Removed global compilation forward to test (change reverted). --------- Co-authored-by: Benoit Denkinger <benoit.denkinger@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CLUSTER_ALIASfrom define to parameter, to avoid includingpulp_soc_defines.sv. For proper functionality whenCLUSTER_ALIASis defined, update to the instantiation ofXBAR_PEis required.