Conversation
phsauter
requested changes
Jun 17, 2026
phsauter
left a comment
phsauter
left a comment
Collaborator
There was a problem hiding this comment.
Some cleanup to explain the difference between clr and other signals and to unify the comments a bit more. Should be easily doable by LLM.
Additionally the Readme needs updating:
- cc_stream_arbiter_flushable is removed
- rst_ni and clr_i need to be mentioned and their purpose explained
- The use of the FF macros should be mentioned in the Readme.
niwis
force-pushed
the
nw/clr-v2
branch
2 times, most recently
from
d15f0f2 to
fd34812
Compare
Collaborator
Author
|
Thanks, should all be addressed now. |
Add active-high synchronous clear inputs to sequential building-block modules and convert affected state elements to clearable register macros. Keep tc_sync instantiations on the tech-cell interface without clr_i while preserving clear behavior in the surrounding common cells. Co-authored-by: Philippe Sauter <phsauter@iis.ee.ethz.ch>
Rename clear_i to restart_i to distinguish the filter restart behavior from clr_i, which clears all state to reset values. Co-authored-by: Philippe Sauter <phsauter@iis.ee.ethz.ch>
Remove the separate cc_stream_arbiter_flushable source and make the main stream arbiter carry the clearable implementation. Update the round-robin arbiter clear API, stream crossbar/omega-net users, manifests, waivers, and tests accordingly. Co-authored-by: Philippe Sauter <phsauter@iis.ee.ethz.ch>
Normalize clk_i, rst_ni, clr_i, and flush_i descriptions across affected modules and document the common sequential ports and macro usage in the README. Co-authored-by: Philippe Sauter <phsauter@iis.ee.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an active-high synchronous clear
clr_ito all modules, clearing all FFS to their reset value (analogous torst_ni). Streamline the codebase by consistently using register macros for sequential logic.Design principles:
clr_ishall clear all FFs, similar torst_ni.clr_i.clr_i. If a an existing functional clear only clears a subset of FFs, rename that port to something distinctively else and addclr_i.The previous
stream_arbiterwrapper is now redundant and replaced by the previousstream_arbiter_flushable.Sequential modules where no synchronous clear was added:
cdc_*clk_*edge_propagator*isochronous_*rstgen*