Struct-to-interface converters for MAGIA#73
Merged
FrancescoConti merged 4 commits intomasterfrom Feb 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces struct-to-interface conversion macros for the HCI (Heterogeneous Cluster Interconnect) system to support MAGIA integration. It also includes a critical bug fix in the router module and updates to the interconnect logic for proper signal handling.
Changes:
- Added struct typedef and assignment macros to enable integration with legacy code and manual struct definitions
- Fixed a critical self-assignment bug in the ECC handshake logic of the router
- Updated interconnect module to properly tie ready signals and remove incorrect assertions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rtl/common/hci_helpers.svh | Added struct typedef macros (HCI_TYPEDEF_REQ_T, HCI_TYPEDEF_RSP_T) and assignment macros (HCI_ASSIGN_TO_INTF, HCI_ASSIGN_FROM_INTF) with documentation; added Victor Isachi to authors |
| rtl/interco/hci_router.sv | Fixed self-assignment bug where postfifo.r_evalid was assigned to itself instead of postfifo.r_valid |
| rtl/interco/hci_log_interconnect_l2.sv | Tied mems[i].r_ready and mems[i].r_eready to constant values; removed incorrect synthesis assertions for r_valid |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Bypass-merging as the change is purely additive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new struct typedef and assignment macros to the HCI helpers, updates interface handling in the interconnect logic, and makes a minor fix in the router module. The main focus is on improving code integration and simplifying struct-to-interface assignments in the hardware interconnect code, in particular for support of MAGIA.
Enhancements to HCI helpers and struct/interface integration:
HCI_TYPEDEF_REQ_TandHCI_TYPEDEF_RSP_Tfor request and response types, enabling easier integration with legacy code and manual struct definitions.HCI_ASSIGN_TO_INTFandHCI_ASSIGN_FROM_INTFto simplify mapping between struct-based and interface-based initiators and targets.hci_helpers.svhto describe the new struct typedefs and assignment macros, including usage notes and integration guidance.hci_helpers.svh.Interconnect and router module updates:
hci_log_interconnect_l2.sv, tiedmems[i].r_readyandmems[i].r_ereadyto constant values, and removed synthesis-time assertions forr_valid. [1] [2]hci_router.svso thatpostfifo.r_evalidis now tied topostfifo.r_validinstead of itself, correcting ECC handshake logic.