Skip to content

Struct-to-interface converters for MAGIA#73

Merged
FrancescoConti merged 4 commits intomasterfrom
fc/magia
Feb 19, 2026
Merged

Struct-to-interface converters for MAGIA#73
FrancescoConti merged 4 commits intomasterfrom
fc/magia

Conversation

@FrancescoConti
Copy link
Copy Markdown
Member

This pull request introduces new struct typedef and assignment macros to the HCI helpers, updates interface handling in the interconnect logic, and makes a minor fix in the router module. The main focus is on improving code integration and simplifying struct-to-interface assignments in the hardware interconnect code, in particular for support of MAGIA.

Enhancements to HCI helpers and struct/interface integration:

  • Added struct typedef macros HCI_TYPEDEF_REQ_T and HCI_TYPEDEF_RSP_T for request and response types, enabling easier integration with legacy code and manual struct definitions.
  • Introduced assignment macros HCI_ASSIGN_TO_INTF and HCI_ASSIGN_FROM_INTF to simplify mapping between struct-based and interface-based initiators and targets.
  • Updated documentation in hci_helpers.svh to describe the new struct typedefs and assignment macros, including usage notes and integration guidance.
  • Added Victor Isachi to the file authorship header in hci_helpers.svh.

Interconnect and router module updates:

  • In hci_log_interconnect_l2.sv, tied mems[i].r_ready and mems[i].r_eready to constant values, and removed synthesis-time assertions for r_valid. [1] [2]
  • Fixed assignment in hci_router.sv so that postfifo.r_evalid is now tied to postfifo.r_valid instead of itself, correcting ECC handshake logic.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces struct-to-interface conversion macros for the HCI (Heterogeneous Cluster Interconnect) system to support MAGIA integration. It also includes a critical bug fix in the router module and updates to the interconnect logic for proper signal handling.

Changes:

  • Added struct typedef and assignment macros to enable integration with legacy code and manual struct definitions
  • Fixed a critical self-assignment bug in the ECC handshake logic of the router
  • Updated interconnect module to properly tie ready signals and remove incorrect assertions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
rtl/common/hci_helpers.svh Added struct typedef macros (HCI_TYPEDEF_REQ_T, HCI_TYPEDEF_RSP_T) and assignment macros (HCI_ASSIGN_TO_INTF, HCI_ASSIGN_FROM_INTF) with documentation; added Victor Isachi to authors
rtl/interco/hci_router.sv Fixed self-assignment bug where postfifo.r_evalid was assigned to itself instead of postfifo.r_valid
rtl/interco/hci_log_interconnect_l2.sv Tied mems[i].r_ready and mems[i].r_eready to constant values; removed incorrect synthesis assertions for r_valid

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@FrancescoConti
Copy link
Copy Markdown
Member Author

Bypass-merging as the change is purely additive.

@FrancescoConti FrancescoConti merged commit b7253f4 into master Feb 19, 2026
@FrancescoConti FrancescoConti deleted the fc/magia branch February 19, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants