Skip to content

Conversation

@lukamac
Copy link
Collaborator

@lukamac lukamac commented Feb 7, 2024

I fixed a few inconsistencies:

  • stride was still an argument for neureka_task_set_op_to_conv, even though it's not used
  • norm, quant structures didn't have bitwidths specified
  • padding dim order to top, bottom, left, right

@lukamac lukamac requested a review from Scheremo February 7, 2024 14:24
@Scheremo
Copy link

Scheremo commented Feb 7, 2024

LGTM!

@lukamac lukamac merged commit a8765d1 into main Feb 7, 2024
@lukamac lukamac deleted the small-fixes branch February 7, 2024 16:20
lukamac added a commit that referenced this pull request Apr 9, 2025
* Remove unused stride from neureka_task_set_op_to_conv

* Fix norm and quant struct types

* Fix header guard to all caps

* Fix padding dim order to be consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants